Use CancellationToken to cancel Explorer index search task #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hey @taooceros whats the issue this is fixing? and how do i repro it? |
Member
all good i saw the comment in the othe PR:
|
Member
|
is this problem happening in dev? |
Member
Author
Not sure, but I believe it could happen. |
Merged
Member
|
is this still needed now the async model is in? |
Member
Author
No, I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy fix but compromised. I think it would be better if we can use full async instead of
GetAwaitor().GetResult.Link to #195 Explorer plugin cause threadpool task shortage.
#233 may allow this to become better if we don't need to create a new CancellationTokenSource but use the one in the main thread, and if we can make plugin use Task as result type, this can become even better that don't need to wait the result.