Skip to content

Conversation

@JamesNZL
Copy link
Contributor

@JamesNZL JamesNZL commented Jun 15, 2023

As per discussion #2189, this PR adds another key binding to select the next/previous results.

Adds Ctrl+W alongside the existing Ctrl+P and Ctrl+K bindings to select previous; and
adds Ctrl+S alongside the existing Ctrl+N and Ctrl+J bindings to select next.

Idea behind this is to make it easier to cycle through results when you only have your left hand; as the existing bindings/arrow keys are difficult to use in this case.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

ZIndex

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:JamesNZL/Flow.Launcher.git repository
on the dev branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5275354041/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor
Copy link
Contributor

LGTM. Is it ok to merge this? @Flow-Launcher/team

@jjw24
Copy link
Member

jjw24 commented Oct 3, 2023

Let's hold off for now per this comment from onesound #2189 (comment), I don't think we have figured out the whole thing yet.

@onesounds
Copy link
Contributor

I'm sorry. I missed this review request notification. This PR should have been applied.

Anyway, I am currently working on the function of customizing all shortcut keys as a top priority, and after this work, the user can set the desired shortcut key. I promise to apply it as soon as possible. Please wait a little longer for this PR.

@VictoriousRaptor VictoriousRaptor mentioned this pull request Apr 24, 2024
12 tasks
@jjw24 jjw24 closed this in #2648 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The option to use tab or alt+number to navigate between results [Describe Your Feature] "Tab" for next item in search results

4 participants