Add Exploere Customization #194

taooceros · 2020-11-04T00:05:53Z

Link to #193
This is only for program plugin for now.

taooceros · 2020-11-04T00:08:26Z

Question: Maybe this should be a global setting?

jjw24 · 2020-11-04T10:53:34Z

Question: Maybe this should be a global setting?

I think this can be a global setting. This basically allows the user to open the containing folder using another program other than Windows explorer right? This can be useful for Explorer plugin as well.

jjw24 · 2020-11-04T10:54:47Z

hey in the code 'Explorer' has a typo in several places. Can you see if there is something in SharedCommands class that you can use rather than hardcoding the word in.

jjw24 · 2020-11-04T11:04:04Z

Question: Maybe this should be a global setting?

I think this can be a global setting. This basically allows the user to open the containing folder using another program other than Windows explorer right? This can be useful for Explorer plugin as well.

On second thought, maybe no need for global, leave this to the individual plugin to implement, because not all plugins do this.

taooceros · 2020-11-04T12:40:49Z

True, but I think program plugin, explorer, and potential everything plugin may use the same setting? Though I think setting them seperately is not hard.

jjw24 · 2020-11-08T21:26:38Z

hey @taooceros just made a couple minor changes, let me know if it is all good

taooceros

I plan to add the customized args aligning with what I have done in the Everything plugin, by adding the default args with select,[path], and allows users to use %s and %f to customize their selection for the containing folder.

Plugins/Flow.Launcher.Plugin.Program/Settings.cs

jjw24 · 2020-11-09T08:33:11Z

Plugins/Flow.Launcher.Plugin.Program/Programs/UWP.cs

-                            Main.StartProcess(Process.Start, new ProcessStartInfo(Package.Location));
+                            Main.StartProcess(Process.Start, new ProcessStartInfo(
+                            !string.IsNullOrEmpty(Main._settings.CustomizedExplorer) ? Main._settings.CustomizedExplorer:Settings.Explorer,
+                            $"{Main._settings.CustomizedArgs} \"{Package.Location}\"".Trim()));


does UWP work with Args? Since "/select,%f" is now the default init

Well...That's an issue... Let me take a look on solution.

i got it working by removing CustomizedAgs, if it doesnt work at all for UWP, perhaps remove it?

jjw24 · 2020-11-09T08:35:00Z

Plugins/Flow.Launcher.Plugin.Program/Languages/en.xaml

+    <system:String x:Key="flowlauncher_plugin_program_customizedexplorer">Customized Explorer</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_args">Args</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_tooltip_customizedexplorer">You can customized the explorer used for opening the container folder by inputing the Environmental Variable of the explorer you want to use. It will be useful to use CMD to test whether the Environmental Variable is avaliable.</system:String>
+    <system:String x:Key="flowlauncher_plugin_program_tooltip_args">Enter the customized args you want to add for your customized explorer. %s for parent directory, %f for full path (which only works for win32). Check the explorer's website for details.</system:String>


sorry i am not too across how the %s and %f option can be used. Could you give me an example?

%s is the parent directory and %f is the file path (.exe, .lnk, etc.) I get the idea from the everything plugin which can select the file while opening the parent directory. However, that seems may work not good for uwp.

oh ok so this option allows for win32 programs to open both file and parent directory when using 'open containing folder' ?

Yes, let me think how I can fix that. If I can't, I will remove that

no logic changes

Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs

…d make code more readable

…r into CustomizeExplorer

taooceros

It seems that for me, the layout is a bit exceed the border

jjw24 · 2020-11-09T10:45:09Z

It seems that for me, the layout is a bit exceed the border

Oh that's strange. Maybe you can reduce the width of the CustomizeExplorer textbox a little bit. I was trying to align them up with the others.

jjw24 · 2020-11-09T19:21:38Z

Once uwp is sorted we can get this in

taooceros · 2020-11-10T02:39:08Z

Once uwp is sorted we can get this in

Oh sorry I forget to mention, it has been solved by moving the default to %s.

jjw24 · 2020-11-10T08:18:02Z

Once uwp is sorted we can get this in

Oh sorry I forget to mention, it has been solved by moving the default to %s.

hey I just tested it out, UWP still not working...

taooceros · 2020-11-10T09:40:27Z

hey I just tested it out, UWP still not working...

Hey I have tested, too, it works....... Which explorer and args are you using?

jjw24 · 2020-11-10T09:55:24Z

hey I just tested it out, UWP still not working...

Hey I have tested, too, it works....... Which explorer and args are you using?

Strange. I just remove roaming profile then start, using the default, which is %s for args

taooceros · 2020-11-10T12:45:55Z

Strange. I just remove roaming profile then start, using the default, which is %s for args

Sorry I have found the issue; I will fix that soon. It works fine for me before is because I clear the args box.......😅

jjw24

👍

Add Exploere Customize to Program Plugin

465146d

taooceros changed the title ~~Add Exploere Customize to Program Plugin~~ Add Exploere Customization Nov 4, 2020

taooceros requested a review from jjw24 November 4, 2020 00:06

jjw24 added enhancement New feature or request review in progress Indicates that a review is in progress for this PR labels Nov 4, 2020

taooceros and others added 7 commits November 4, 2020 21:56

Add customized args

5ba4e51

Add customized args

9de105b

bump version Program plugin

ae8a6a0

move text to language xml

8df4de9

use const instead of strings

b962e4d

remove empty string init

51ea7ab

update property name and use const

d5d263b

taooceros commented Nov 9, 2020

View reviewed changes

Plugins/Flow.Launcher.Plugin.Program/Settings.cs Outdated Show resolved Hide resolved

Add more customized args

ead4c9a

jjw24 reviewed Nov 9, 2020

View reviewed changes

adjusted layout of the Add buttons and CustomizedExplorer fields

39233cb

no logic changes

jjw24 reviewed Nov 9, 2020

View reviewed changes

Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs Outdated Show resolved Hide resolved

taooceros added 2 commits November 9, 2020 18:12

Customize select funtionality in win32 except globally in program, an…

3d06ade

…d make code more readable

Merge branch 'CustomizeExplorer' of github.com:taooceros/Flow.Launche…

82afd37

…r into CustomizeExplorer

taooceros commented Nov 9, 2020

View reviewed changes

Adjust ui to not exceed boundary

c5720df

Fix opening UWP containing folder

e16f0e4

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 10, 2020

jjw24 assigned taooceros Nov 10, 2020

jjw24 approved these changes Nov 10, 2020

View reviewed changes

jjw24 merged commit 8010179 into Flow-Launcher:dev Nov 10, 2020

jjw24 mentioned this pull request Nov 10, 2020

Release 1.4.0 | Plugin 1.2.2 #191

Merged

JohnTheGr8 mentioned this pull request Nov 11, 2020

Revert unintended change #196

Merged

taooceros deleted the CustomizeExplorer branch November 30, 2020 02:49

Uh oh!

Add Exploere Customization #194

Add Exploere Customization #194

Uh oh!

Conversation

taooceros commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Nov 4, 2020

Uh oh!

jjw24 commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Nov 4, 2020

Uh oh!

jjw24 commented Nov 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jjw24 Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

taooceros Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

jjw24 Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

jjw24 Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

taooceros Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

jjw24 Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

taooceros Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

taooceros left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjw24 commented Nov 9, 2020

Uh oh!

jjw24 commented Nov 9, 2020

Uh oh!

taooceros commented Nov 10, 2020

Uh oh!

jjw24 commented Nov 10, 2020

Uh oh!

taooceros commented Nov 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 commented Nov 10, 2020

Uh oh!

taooceros commented Nov 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjw24 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

taooceros commented Nov 4, 2020 •

edited

Loading

jjw24 commented Nov 4, 2020 •

edited

Loading

jjw24 commented Nov 4, 2020 •

edited

Loading

jjw24 commented Nov 4, 2020 •

edited

Loading

jjw24 commented Nov 8, 2020 •

edited

Loading

taooceros left a comment •

edited

Loading

taooceros commented Nov 10, 2020 •

edited

Loading

taooceros commented Nov 10, 2020 •

edited

Loading