Fix preview hotkey issue #1932
Fix preview hotkey issue #1932
Conversation
Check if preview hotkey is a valid KeyGesture when setting and loading Ban more printable characters
| try | ||
| { | ||
| var converter = new KeyGestureConverter(); | ||
| var key = (KeyGesture)converter.ConvertFromString(Settings.PreviewHotkey); |
There was a problem hiding this comment.
probably this is better? ConvertFromInvariantString(String)
Correct me if i am wrong
There was a problem hiding this comment.
Does it make a difference?
There was a problem hiding this comment.
Probably CultureInfo doesn't matter here, we are not dealing with datetime, decimal or float types.
| /// </summary> | ||
| /// <param name="validateKeyGestrue">Try to validate hotkey as a KeyGesture.</param> | ||
| /// <returns></returns> | ||
| public bool Validate(bool validateKeyGestrue = false) |
There was a problem hiding this comment.
Do we need this option? Shouldn't we always validate?
If needed can we set validate to true by default?
There was a problem hiding this comment.
This option is for KeyGesture class and currently we use it for the preview hotkey but not for the toggle hotkey or custom query hotkey. We only need to validate it for preview hotkey.
| /// <summary> | ||
| /// Designed for Preview Hotkey and KeyGesture. | ||
| /// </summary> | ||
| public bool ValidateKeyGesture { get; set; } = false; |
There was a problem hiding this comment.
Same here, should it be true by default?
3 participants
Changes
Tests