Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Feb 11, 2023

fix #1894

Tested:

  • Option works

@github-actions

This comment has been minimized.

@jjw24
Copy link
Member

jjw24 commented Feb 18, 2023

What about making the default as false? When true alot of subfolders with matching paths come out that confuses users not familiar with this option.

@scharmach
Copy link

What about making the default as false? When true alot of subfolders with matching paths come out that confuses users not familiar with this option.

Not only confusing, I also think that this is less productive, at least for me. I now have to narrow down my searches a lot more than before due to the sheer amount of results that I'm getting for some words.

I would make false the default too.

@taooceros
Copy link
Member Author

ok makes sense

@github-actions

This comment has been minimized.

@jjw24 jjw24 added this to the 1.13.1 milestone Feb 20, 2023
@jjw24 jjw24 added the bug Something isn't working label Feb 20, 2023
@jjw24 jjw24 enabled auto-merge February 20, 2023 21:10
@github-actions
Copy link

github-actions bot commented Feb 20, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (10)

browserbookmark
copylink
copyurl
generalsetting
indexsearchexcludedpaths
lbx
manageactionkeywords
Popu
quickaccesslinks
Reloadable

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the everything_full_path_option branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4227081949/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 merged commit 3b05ee2 into dev Feb 20, 2023
@jjw24 jjw24 deleted the everything_full_path_option branch February 20, 2023 21:24
@jjw24 jjw24 modified the milestones: 1.13.1, 1.14.0 Feb 26, 2023
@jjw24 jjw24 mentioned this pull request Mar 2, 2023
@VictoriousRaptor
Copy link
Contributor

Just found that it breaks regex searches. if I input wsa*.7z when it's true it can't match files like wsa_1254798tihdsafgoih.7z.

@jjw24
Copy link
Member

jjw24 commented Mar 5, 2025

Let's issue this if you haven't already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] 程序插件的文件夹结果排序

5 participants