Fix bugs in explorer plugin

[VictoriousRaptor]

Changes:

• Fix [BUG] - Explorer Plugin crash when first input is a colon ":" #1802 (Fix null subtitle when creating disk result)
• Fix [BUG] Variable %LocalAppData% in path cause exception #1796 (Only expand environment var when path starts with %)
• Use case-insensitive comparator for path results
• Use api for subpath check

Tests:

• A single ":" when excluded path is not empty won't cause exception. (1802)
• Unit test for environment path expansion
• Unit test for subpath check
• Unit test for result comparator

[jjw24]

Please update description with what you have tested :)

[jjw24]

what's the issue with this check?

[VictoriousRaptor]

a path string starts with another doesn't necessarily mean it's contains the other one (unless ending with slash is guaranteed). like c:\program files and c:\program

[jjw24]

@z1nc0r3 just a FYI the issue with ':' is addressed here already.

[VictoriousRaptor]

@z1nc0r3 just a FYI the issue with ':' is addressed here already.

that's a bit different. that pr was to ignore queries with ':'. this one is to fix the crash issue.

[VictoriousRaptor]

The only other thing I picked up is the use of %USERNAME% in the form of c:\users\%USERNAME%\downloads. https://www.elevenforum.com/t/complete-list-of-environment-variables-in-windows-11.11212/ I suppose though you can use %USERPROFILE% to achieve the same as using %USERNAME%

Perhaps add an exclusion for %USERNAME%?

Just found something interesting. If you create a folder called %appdata% in some folder like D:\foo, then try to cd D:\foo\%appdata% in cmd or type it in the location bar of windows explorer, it doesn't work. But you can still enter it by double clicking. Guess we need to reconsider how to deal with it.

Edit: Only expand when matching ...\%blabla%\....

[taooceros]

The only other thing I picked up is the use of %USERNAME% in the form of c:\users\%USERNAME%\downloads. https://www.elevenforum.com/t/complete-list-of-environment-variables-in-windows-11.11212/ I suppose though you can use %USERPROFILE% to achieve the same as using %USERNAME%
Perhaps add an exclusion for %USERNAME%?

Just found something interesting. If you create a folder called %appdata% in some folder like D:\foo, then try to cd D:\foo\%appdata% in cmd or type it in the location bar of windows explorer, it doesn't work. But you can still enter it by double clicking. Guess we need to reconsider how to deal with it.

Edit: Only expand when matching ...\%blabla%\....

What about check whether the path exists before expanding environmental variable?

[VictoriousRaptor]

What about check whether the path exists before expanding environmental variable?

Expanding is before checking the path is incomplete (user inputting and without trailing '\'). For this bug this pr is enough imo. Even Windows Explorer can't deal with this situation perfectly.

[taooceros]

Expanding is before checking the path is incomplete (user inputting and without trailing ''). For this bug this pr is enough imo. Even Windows Explorer can't deal with this situation perfectly.

lol ok

[VictoriousRaptor]

Expanding is before checking the path is incomplete (user inputting and without trailing ''). For this bug this pr is enough imo. Even Windows Explorer can't deal with this situation perfectly.

lol ok

It can be done but I don't really want to do it. In this pr @kubalav 's path should be correctly parsed. but paths like d:%appdata% still can't be handled correctly.

[jjw24]

nice, this will be helpful because through out explorer there are dup code to add trailing slash.