Skip to content

Conversation

@VictoriousRaptor
Copy link
Contributor

Explorer shortcut in #1275 is laggy. No need to calculate the shortcut when the shortcut is not in the query.

@VictoriousRaptor VictoriousRaptor added bug Something isn't working Dev branch only An issue or fix for the Dev branch build labels Jan 12, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.11.1 milestone Jan 12, 2023
@VictoriousRaptor VictoriousRaptor self-assigned this Jan 12, 2023
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

laggy

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:VictoriousRaptor/Flow.Launcher.git repository
on the ExpandShortcutsWhenNeeded branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3902085050/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

queryBuilder.Replace('@' + shortcut.Key, shortcut.Expand());
}

string customExpanded = queryBuilder.ToString();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I feel like this is somewhat weird....I consider it's ok

@taooceros taooceros merged commit 29282e4 into Flow-Launcher:dev Jan 12, 2023
@VictoriousRaptor VictoriousRaptor deleted the ExpandShortcutsWhenNeeded branch January 13, 2023 06:18
@VictoriousRaptor VictoriousRaptor removed this from the 1.11.1 milestone Jan 13, 2023
@jjw24 jjw24 modified the milestones: 1.11.1, 1.12.0 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Dev branch only An issue or fix for the Dev branch build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants