Skip to content

Refactor clear log folder logic #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

Refactor clear log folder logic #1757

merged 1 commit into from
Jan 3, 2023

Conversation

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Jan 2, 2023 •
edited
Loading

Changes:

  • Clear logs of all versions
  • Use binding for button text
  • Move open log dir to vm
  • Text: "Bytes" to "B"

Tests:

  • Logs of all versions are cleared
  • Log size text updated after clearing

@VictoriousRaptor
Refactor clear log folder logic
4d10089 
Clear logs of all versions

Use binding for button text

Move open log dir to vm
@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Jan 2, 2023
@VictoriousRaptor VictoriousRaptor added this to the 1.11.1 milestone Jan 2, 2023
@VictoriousRaptor VictoriousRaptor self-assigned this Jan 2, 2023
@VictoriousRaptor VictoriousRaptor added the bug Something isn't working label Jan 2, 2023
@VictoriousRaptor VictoriousRaptor merged commit 6615d5e into Flow-Launcher:dev Jan 3, 2023
@jjw24 jjw24 removed the enhancement New feature or request label Jan 3, 2023
@jjw24 jjw24 modified the milestones: 1.11.1, 1.12.0 Jan 22, 2023
@jjw24 jjw24 mentioned this pull request Jan 24, 2023
Merged
@VictoriousRaptor VictoriousRaptor deleted the ClearLog branch April 22, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onesounds onesounds onesounds approved these changes

@jjw24 jjw24 Awaiting requested review from jjw24

@taooceros taooceros Awaiting requested review from taooceros

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

bug Something isn't working

Projects

Work In Progress
Archived in project

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@VictoriousRaptor @onesounds @jjw24