Skip to content

Fix crowdin spell check action #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 2, 2023
Merged

Fix crowdin spell check action #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
58f7be0
Tweak file exclusion rule
VictoriousRaptor Jan 2, 2023
fec3b69
Exclude l10n_dev branch
VictoriousRaptor Jan 2, 2023
3fd9872
Disable cancel in progress
VictoriousRaptor Jan 2, 2023
f4dcb29
Temporarily check all for test
VictoriousRaptor Jan 2, 2023
1be5ec2
Fix checking head ref
VictoriousRaptor Jan 2, 2023
3d7762b
Stop checking Resources.resx
VictoriousRaptor Jan 2, 2023
87cebbf
Update texts
VictoriousRaptor Jan 2, 2023
1f5f15c
Update regex
VictoriousRaptor Jan 2, 2023
483371e
update exclude list
VictoriousRaptor Jan 2, 2023
1c1602f
Test l10n_dev
VictoriousRaptor Jan 2, 2023
9e05cc8
ignore resx
VictoriousRaptor Jan 2, 2023
80b867f
update
VictoriousRaptor Jan 2, 2023
46e1385
fix branch head
VictoriousRaptor Jan 2, 2023
ceab134
update newline
VictoriousRaptor Jan 2, 2023
97ca208
update regex
VictoriousRaptor Jan 2, 2023
234dfbf
test
VictoriousRaptor Jan 2, 2023
42447a5
remove test code
VictoriousRaptor Jan 2, 2023
4673120
Exclude l10n_dev branch
VictoriousRaptor Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/actions/spelling/excludes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@
^\.github/actions/spelling/
^\Q.github/workflows/spelling.yml\E$
# Custom
(?:^|/)Languages/(?!en.xaml)
(?:^|/)Languages/(?!en\.xaml)
Scripts/
Plugins/Flow.Launcher.Plugin.WindowsSettings/Properties/
Plugins/Flow.Launcher.Plugin.WindowsSettings/WindowsSettings.json
Plugins/Flow.Launcher.Plugin.WebSearch/setting.json
(?:^|/)FodyWeavers.xml
\.resx$
^\QPlugins/Flow.Launcher.Plugin.WindowsSettings/WindowsSettings.json\E$
^\QPlugins/Flow.Launcher.Plugin.WebSearch/setting.json\E$
(?:^|/)FodyWeavers\.xml
.editorconfig
ignore$
\.ps1$
Expand Down
6 changes: 5 additions & 1 deletion .github/actions/spelling/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,8 @@ runas
dpi
popup
ptr
pluginindicator
pluginindicator
TobiasSekan
Img
img
resx
1 change: 1 addition & 0 deletions .github/actions/spelling/patterns.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@

# html tag
<\w+[^>]*>
</\w+[^>]*>

#http/https
(?:\b(?:https?|ftp|file)://)[-A-Za-z0-9+&@#/%?=~_|!:,.;]+[-A-Za-z0-9+&@#/%=~_|]
4 changes: 2 additions & 2 deletions .github/workflows/spelling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ jobs:
outputs:
followup: ${{ steps.spelling.outputs.followup }}
runs-on: ubuntu-latest
if: "contains(github.event_name, 'pull_request') || github.event_name == 'push'"
if: (contains(github.event_name, 'pull_request') && github.head_ref != 'l10n_dev') || github.event_name == 'push'
concurrency:
group: spelling-${{ github.event.pull_request.number || github.ref }}
# note: If you use only_check_changed_files, you do not want cancel-in-progress
cancel-in-progress: true
cancel-in-progress: false
steps:
- name: check-spelling
id: spelling
Expand Down