Skip to content

Refactor Toggle Game Mode logic in main window #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 24, 2022
Merged

Refactor Toggle Game Mode logic in main window #1712

merged 7 commits into from
Dec 24, 2022

Conversation

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Dec 23, 2022

Changes:

  • Refactored Toggle Game Mode logic.
  • Fixed an issue that changing Open Result modifier in settings window won't reflect to main window.
  • Formatting and removed redundant codes.

Tests:

  • Can toggle game mode by hotkey and context menu.
  • Changing Open Result modifier in settings window affects main window

@VictoriousRaptor VictoriousRaptor self-assigned this Dec 23, 2022
@VictoriousRaptor VictoriousRaptor added the bug Something isn't working label Dec 23, 2022
@VictoriousRaptor VictoriousRaptor changed the title Refactor some logic in main window Refactor Toggle Game Mode logic in main window Dec 23, 2022
@jjw24 jjw24 added this to the 1.11.0 milestone Dec 24, 2022
@VictoriousRaptor VictoriousRaptor merged commit 9027a20 into Flow-Launcher:dev Dec 24, 2022
@jjw24 jjw24 mentioned this pull request Dec 30, 2022
Merged
@VictoriousRaptor VictoriousRaptor deleted the RefactorMainWindow branch December 30, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

bug Something isn't working

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@VictoriousRaptor @jjw24