Remove await Task.Run for IconDelegate #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's trust plugin developer when they use that for icon
Member
|
@taooceros please list what's tested. |
Member
What do they need to do? |
Contributor
No change needed. Currently two ways to provide an icon: path to the image or a delegate. |
Contributor
|
Just found that this is not the actual problem. UWP uses IcoPath now. Blinking when typing with always preview enabled is because selected item is rapidly changing when typing. |
Member
|
Shall we close this then? |
Contributor
it's up to tao |
Member
Author
Let's keep the behavior the same as before. The vscode plugin is still using the Icon delegate. |
Member
Author
I will test once I get back to my comp |
VictoriousRaptor
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's trust plugin developer when they use that for icon
This will solve the icon blink for uwp and some other plugin that use IconDelegate.
Tested: