Skip to content

plugin/ProcessKiller: enhancements to the kill-all functionality #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

plugin/ProcessKiller: enhancements to the kill-all functionality #167

merged 2 commits into from
Oct 12, 2020

Conversation

@JohnTheGr8
Copy link
Member

@JohnTheGr8 JohnTheGr8 commented Oct 11, 2020

  1. do not show a "kill all instances" item in the context-menu listing of "kill all X processes"
  2. make the "kill all X processes" result item a bit nicer

Before:
image
After:
image

  1. hide the "kill all X processes" option when the associated executable path is empty

Before:
image
After:
image

@JohnTheGr8
plugin/pkiller: fix context menu results
01f98b1 
do not show the "kill all instances" context menu option when the
context menu itself is triggered from the "kill all X processes" result
@JohnTheGr8
plugin/pkiller: improve kill-all option
b1ca71b 
- better title, add count of matches in subtitle, use process icon
- hide option when executable path is empty
@JohnTheGr8 JohnTheGr8 added the enhancement New feature or request label Oct 11, 2020
@JohnTheGr8 JohnTheGr8 requested a review from jjw24 October 11, 2020 21:21
@JohnTheGr8 JohnTheGr8 self-assigned this Oct 11, 2020
@jjw24 jjw24 merged commit 1e4bc07 into Flow-Launcher:dev Oct 12, 2020
@jjw24 jjw24 mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@JohnTheGr8 JohnTheGr8

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnTheGr8 @jjw24