Skip to content

Add option to enable/disable UWP indexing #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 22, 2022
Merged

Add option to enable/disable UWP indexing #1669

merged 7 commits into from
Dec 22, 2022

Conversation

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Dec 17, 2022 •
edited
Loading

Closes #1659

  • Add an option to enable/dsiable UWP indexing
  • Fix double clicking on program source listview header would open edit dialog.

Tests:

  • UWP can be hidden/indexed by toggling the option.
  • Double click on header won't open edit dialog.

@VictoriousRaptor VictoriousRaptor self-assigned this Dec 17, 2022
@jjw24 jjw24 added the bug Something isn't working label Dec 18, 2022
@jjw24 jjw24 added this to the Future milestone Dec 18, 2022
@VictoriousRaptor VictoriousRaptor changed the title Disable programs from PATH by default Add option to enable/disable UWP indexing Dec 18, 2022
@taooceros
Copy link
Member

taooceros commented Dec 20, 2022

@VictoriousRaptor That seems to be too complicated to be done. We can merge this first

@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review December 21, 2022 02:22
@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Dec 21, 2022
@VictoriousRaptor VictoriousRaptor modified the milestones: Future, 1.10.2 Dec 21, 2022
@jjw24 jjw24 modified the milestones: 1.10.2, 1.11.0 Dec 21, 2022
@VictoriousRaptor VictoriousRaptor merged commit bade0fc into Flow-Launcher:dev Dec 22, 2022
@jjw24 jjw24 mentioned this pull request Dec 30, 2022
Merged
@jjw24 jjw24 removed the bug Something isn't working label Dec 30, 2022
@VictoriousRaptor VictoriousRaptor deleted the DisablePATHByDefault branch December 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taooceros taooceros taooceros approved these changes

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

BUG: I cannot disable indexing of PATH (Program plugin)

3 participants

@VictoriousRaptor @taooceros @jjw24