Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Dec 7, 2022

Bump Nuget.CommandLine from 5.7.2 package to 6.3.1

Note:

  • Tried to change nuspec's 'iconUrl 'to 'icon', the result was app.ico no longer exists in the parent folder and in control panel's program uninstallation icon is no longer displaying:
    image
    So reverted back to using iconUrl which the control panel then showed flow's icon again. Maybe related to Squirrel.Windows since it packages the app.

  • Tried globbing when creating the alias for Nuget CommandLine so verson doesnt need to be hardcoded- (Get-ChildItem -Path $env:USERPROFILE\.nuget\packages\NuGet.CommandLine\*\tools\NuGet.exe).FullName but the command returned multiple path, maybe due to the pipeline using caching.

Tested

  • Installing in Windows Sandbox

@jjw24 jjw24 marked this pull request as draft December 7, 2022 03:44
@jjw24 jjw24 marked this pull request as ready for review December 8, 2022 10:25
@jjw24 jjw24 enabled auto-merge (squash) December 8, 2022 10:25
@jjw24 jjw24 self-assigned this Dec 8, 2022
@jjw24 jjw24 requested review from JohnTheGr8 and taooceros December 8, 2022 10:27
@jjw24 jjw24 added the bug Something isn't working label Dec 8, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Dec 8, 2022
@jjw24 jjw24 merged commit c9b50bb into dev Dec 8, 2022
@jjw24 jjw24 deleted the bump_nuget branch December 8, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants