Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Sep 16, 2022

To repro:

  1. Cause an exception
  2. Ctrl + click on the exception report window link
  3. Observe the link is opened twice in two browser tabs
    (If you can debugging locally, you can install GitHub Quick Launcher and type query 'gr' and exception window will pop up. This exception is not an issue with the plugin, but because flow is not run from the expected Local AppData location.)

image

@jjw24 jjw24 added the bug Something isn't working label Sep 16, 2022
@jjw24 jjw24 added this to the 1.9.5 milestone Sep 16, 2022
@jjw24 jjw24 self-assigned this Sep 16, 2022
@jjw24 jjw24 enabled auto-merge September 16, 2022 12:31
@jjw24 jjw24 merged commit 792b383 into dev Sep 16, 2022
@jjw24 jjw24 deleted the fix_exception_duplicate_url_opening branch September 16, 2022 12:39
@Garulf
Copy link
Member

Garulf commented Sep 16, 2022

... I need to update Flox on that I guess. Whoops.

@jjw24
Copy link
Member Author

jjw24 commented Sep 16, 2022

... I need to update Flox on that I guess. Whoops.

I wouldn't suggest you do that because this is run from dev environment, which means it's in a random workspace that is not your standard flow installation location, you will waste effort figuring out where the dev has flow folder placed.

jjw24 added a commit that referenced this pull request Sep 16, 2022
…rl_opening

Fix opening url twice when clicking on exception report link
@jjw24 jjw24 mentioned this pull request Sep 18, 2022
jjw24 added a commit that referenced this pull request Sep 27, 2022
* Merge pull request #1061 from Flow-Launcher/remove_winget_ci

* Merge pull request #991 from Flow-Launcher/context_menu_plugin_site

* Merge pull request #1080 from gissehel/caret-position-fix

* Caret position fix : Include PR #1074

* Merge pull request #1283 from nachmore/dev

* Merge pull request #1296 from nachmore/bug_1284

* Merge pull request #1294 from Flow-Launcher/pluginInfoMultipleActionKeyword

* Merge pull request #1299 from nachmore/bug_1269

* Plugin Exception Draft (#1147)

* Merge pull request #1355 from onesounds/LimitWidth

* Merge pull request #1088 from Flow-Launcher/add_spanish_latin_america

* Merge pull request #1387 from Flow-Launcher/fix_exception_duplicate_url_opening

* Merge pull request #1390 from Flow-Launcher/issue_1371

* Merge pull request #1391 from Flow-Launcher/issue_1366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants