Display Drive Space #1365
Display Drive Space #1365
Conversation
- when Type "d:\", showing graph with free space.
- Colorized(red) when usage space 90% over
|
Possible for other plug-ins to use this design? |
I guess so. if 'progress'(nullable int, 0-100) in result. automatically showing. |
|
Amazing! |
jjw24
added
the
review in progress
| public object Convert(object value, Type targetType, object parameter, CultureInfo culture) | ||
| { | ||
| double progress = (double)value; | ||
| string foreground = "#26a0da"; | ||
|
|
||
| if (progress >= 90) | ||
| { | ||
| foreground = "#da2626"; | ||
| } | ||
|
|
||
| return foreground; | ||
| } |
There was a problem hiding this comment.
@Garulf @onesounds @taooceros Do we want to enable plugins to use progress bar? If so we will need to make this bar colorization customizable by plugin, otherwise any progress above 90 will be red.
There was a problem hiding this comment.
Probably best we don't hard code red here and allow the color to be adjusted in some manner.
Best case scenario it's themed and easily overridden by the plugin.
|
@Garulf @onesounds @taooceros just changed the code a bit to allow plugins to use progress bar by providing the Result.ProgressBar value and optionally setting the color themselves. Let me know if you guys ok with the change, if all good we can merge in. |
cool. I tested it and there's no problem. I think this structure is better. let's merge. |
|
I have not tested but I have looked at the code. I see no issues |
jjw24
removed
the
review in progress
3 participants
Features
Test Case