Fix WebSearch plugin custom icon location #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy images when not in the plugin's default images directory - do not copy if in the default directory or already in user data directory
Load icon image preview on select and only save changes on confirm
jjw24
requested review from
JohnTheGr8,
SysC0mp and
gdziedzic
and removed request for
JohnTheGr8,
SysC0mp and
gdziedzic
JohnTheGr8
requested changes
Aug 15, 2020
Member
JohnTheGr8
left a comment
JohnTheGr8
left a comment
There was a problem hiding this comment.
a few minor nitpicks, looking good otherwise. 👍
JohnTheGr8
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user selects a custom icon in WebSearch:
if the image is outside of the plugin's default Images location then copy across to user data location where the plugin settings folder sits, inside the 'CustomIcons' folder
If the image is inside the CustomIcons folder, do nothing
Updated image selection window so icon image is refreshed when a user selects a new one
This resolves the issue where custom icon images are lost when Flow is updated.
Closing #107