Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Apr 23, 2022

Add exception handling thrown by plugins.

Update user error window to point to plugin's Url.

@taooceros taooceros changed the title Plugin Exception Draft Plugin Exception Apr 23, 2022
@taooceros taooceros self-assigned this Apr 23, 2022
@jjw24
Copy link
Member

jjw24 commented Apr 24, 2022

What's this one?

@taooceros
Copy link
Member Author

What's this one?

Wrap exception come from query plugin do that somewhat redirect the exception caused by plugin to the plugin repo.

@jjw24 jjw24 changed the title Plugin Exception Add handling of exceptions from plugins Apr 24, 2022
@jjw24 jjw24 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 24, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Apr 24, 2022
@jjw24
Copy link
Member

jjw24 commented Apr 24, 2022

Let me know when good for review.

@taooceros
Copy link
Member Author

I will give it a test recently.

@taooceros taooceros requested a review from jjw24 July 4, 2022 21:51
@taooceros
Copy link
Member Author

I think it works.

@taooceros
Copy link
Member Author

image

@taooceros taooceros enabled auto-merge (squash) July 15, 2022 13:42
@jjw24 jjw24 added review in progress Indicates that a review is in progress for this PR and removed review in progress Indicates that a review is in progress for this PR labels Aug 11, 2022
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@taooceros taooceros merged commit fa7057a into dev Aug 12, 2022
@taooceros taooceros deleted the PluginException branch August 12, 2022 13:12
@jjw24 jjw24 modified the milestones: 1.10.0, 1.9.5 Sep 16, 2022
jjw24 pushed a commit that referenced this pull request Sep 16, 2022
@jjw24 jjw24 mentioned this pull request Sep 18, 2022
jjw24 added a commit that referenced this pull request Sep 27, 2022
* Merge pull request #1061 from Flow-Launcher/remove_winget_ci

* Merge pull request #991 from Flow-Launcher/context_menu_plugin_site

* Merge pull request #1080 from gissehel/caret-position-fix

* Caret position fix : Include PR #1074

* Merge pull request #1283 from nachmore/dev

* Merge pull request #1296 from nachmore/bug_1284

* Merge pull request #1294 from Flow-Launcher/pluginInfoMultipleActionKeyword

* Merge pull request #1299 from nachmore/bug_1269

* Plugin Exception Draft (#1147)

* Merge pull request #1355 from onesounds/LimitWidth

* Merge pull request #1088 from Flow-Launcher/add_spanish_latin_america

* Merge pull request #1387 from Flow-Launcher/fix_exception_duplicate_url_opening

* Merge pull request #1390 from Flow-Launcher/issue_1371

* Merge pull request #1391 from Flow-Launcher/issue_1366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants