BUG: F1 preview of images does not fill the whole preview area

[TheBestPessimist]

Checks

• I have checked that this issue has not already been reported.

• I am using the latest version of Flow Launcher.

Problem Description

I have a bunch of JPEG and PNG images which i use as wallpapers, so they all have resolution of 1080p or higher.

While using FL to search and preview my pictures, it seems picture preview does not fill the whole preview area: some pics are small, others are larger, etc

What I expected is that FL fills the preview area according to the "highest dimension (of the pic/preview area)" or somehow the biggest ratio of pic vs preview area.

Screenshots

Please see here: https://cdn.discordapp.com/attachments/917500039931256933/1093227949655855134/FL_preview_issue.gif

Flow Launcher Version

1.14.0. some beta version

Windows Build Number

Microsoft Windows [Version 10.0.22621.1485]

Error Log

No response

[ligq]

I also have this issue.

[VictoriousRaptor]

It's something about image dpi. For image DPi > 96 its height and width are calculated incorrectly in ImageLoader. Don't know how to fix it. @taooceros any idea?

[taooceros]

you mean this?

Flow.Launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs

Lines 288 to 322 in 8f58d53

	private static BitmapImage LoadFullImage(string path)
	{
	BitmapImage image = new BitmapImage();
	image.BeginInit();
	image.CacheOption = BitmapCacheOption.OnLoad;
	image.UriSource = new Uri(path);
	image.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	image.EndInit();
	if (image.PixelWidth > 320)
	{
	BitmapImage resizedWidth = new BitmapImage();
	resizedWidth.BeginInit();
	resizedWidth.CacheOption = BitmapCacheOption.OnLoad;
	resizedWidth.UriSource = new Uri(path);
	resizedWidth.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	resizedWidth.DecodePixelWidth = 320;
	resizedWidth.EndInit();
	if (resizedWidth.PixelHeight > 320)
	{
	BitmapImage resizedHeight = new BitmapImage();
	resizedHeight.BeginInit();
	resizedHeight.CacheOption = BitmapCacheOption.OnLoad;
	resizedHeight.UriSource = new Uri(path);
	resizedHeight.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	resizedHeight.DecodePixelHeight = 320;
	resizedHeight.EndInit();
	return resizedHeight;
	}
	return resizedWidth;
	}
	return image;
	}
	}

Sorry but I don't have insight at the moment. (will it be the resize causing the issue?)

[VictoriousRaptor]

you mean this?

Flow.Launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs

Lines 288 to 322 in 8f58d53

	private static BitmapImage LoadFullImage(string path)
	{
	BitmapImage image = new BitmapImage();
	image.BeginInit();
	image.CacheOption = BitmapCacheOption.OnLoad;
	image.UriSource = new Uri(path);
	image.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	image.EndInit();
	if (image.PixelWidth > 320)
	{
	BitmapImage resizedWidth = new BitmapImage();
	resizedWidth.BeginInit();
	resizedWidth.CacheOption = BitmapCacheOption.OnLoad;
	resizedWidth.UriSource = new Uri(path);
	resizedWidth.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	resizedWidth.DecodePixelWidth = 320;
	resizedWidth.EndInit();
	if (resizedWidth.PixelHeight > 320)
	{
	BitmapImage resizedHeight = new BitmapImage();
	resizedHeight.BeginInit();
	resizedHeight.CacheOption = BitmapCacheOption.OnLoad;
	resizedHeight.UriSource = new Uri(path);
	resizedHeight.CreateOptions = BitmapCreateOptions.IgnoreColorProfile;
	resizedHeight.DecodePixelHeight = 320;
	resizedHeight.EndInit();
	return resizedHeight;
	}
	return resizedWidth;
	}
	return image;
	}
	}

Sorry but I don't have insight at the moment. (will it be the resize causing the issue?)

Yeah.

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[TheBestPessimist]

bad bot

[VictoriousRaptor]

Looks like comment doesn't remove stale label.

[onesounds]

This issue will be resolved so that the image fills the preview panel area as much as possible.
However, you may find that the image resolution is low (it's set low because it affects the speed of the program), and I'll consider a separate setting for this. (but in now. this is low priority work. )
If you need to check high-resolution images, you're better off using quicklook, (we're working on support for quicklook, which will be merged soon.)