Custom Query Hotkey feature not usable because of incorrect caret position

[stax76]

Describe the bug/issue

Maybe I'm the only user wanting to use this feature. The Custom Query Hotkey feature is not usable because the caret position is at the beginning of the query at index 0. At the end of the query should be a space and after that space is the supposed caret position.

To Reproduce

1. Assign 'b' as 'Action Keyword' for the 'Browser Bookmarks' plugin.
2. Create a Custom Query Hotkey with 'b ' as query.
3. Press the hotkey, caret is at pos 0 instead of pos 2.

Screenshots

Your System

(It's Windows 11)
Microsoft Windows [Version 10.0.22000.493]
Flow Launcher version: 1.9.3

[taooceros]

I also use that feature a lot but hasn't able to reproduce the same issue. Could you share the log as well?

Some has shared the same issue, but the reason is still unclear.

[stax76]

Log file:

2022-03-08.txt

[stax76]

My screen is 4K at 288 DPI, enabled plugins:

Browser Bookmarks (b)
Favorites (*)
Plugin Manager (pm)
Program (p)

I would guess a threading issue, if it's not reproducible I could have a look.

[medlir]

Possibly related to issue #1025 as well where the cursor isn't ending up in the right place for Win+R either.

[stax76]

I can reproduce it consistently and can try to debug it tomorrow.

[taooceros]

I can reproduce it consistently and can try to debug it tomorrow.

That will be awesome! Thank you

Possibly related to issue #1025 as well where the cursor isn't ending up in the right place for Win+R either.

I think they are the same issue. (Both are using ChangeQuery method).

[medlir]

I've been playing with running debug builds for a bit tonight, and while I haven't tracked it down in code, I believe I've found the trigger, which appears to be be setting "Last Query Style" to "Empty last Query" rather than the default of "Select last Query". Wiping out my entire AppData/Roaming/FlowLauncher dir so I have completely clean settings, both custom hotkey and Win+R work as expected on clean startup after skipping the intro help dialog. If you toggle ONLY that setting to "EMpty last Query" AND close and relaunch, on relaunch the cursor will be at the beginning of the line for both custom hotkey and Win+R.

[taooceros]

ok make sense. I will check that part of code tmr (or probably at the weekend)?

[stax76]

Duplicate of #1025

[Garulf]

I've been playing with running debug builds for a bit tonight, and while I haven't tracked it down in code, I believe I've found the trigger, which appears to be be setting "Last Query Style" to "Empty last Query" rather than the default of "Select last Query". Wiping out my entire AppData/Roaming/FlowLauncher dir so I have completely clean settings, both custom hotkey and Win+R work as expected on clean startup after skipping the intro help dialog. If you toggle ONLY that setting to "EMpty last Query" AND close and relaunch, on relaunch the cursor will be at the beginning of the line for both custom hotkey and Win+R.

Oh wow! I could see how that could cause an issue! Thanks for looking into this.

[taooceros]

I've been playing with running debug builds for a bit tonight, and while I haven't tracked it down in code, I believe I've found the trigger, which appears to be be setting "Last Query Style" to "Empty last Query" rather than the default of "Select last Query". Wiping out my entire AppData/Roaming/FlowLauncher dir so I have completely clean settings, both custom hotkey and Win+R work as expected on clean startup after skipping the intro help dialog. If you toggle ONLY that setting to "EMpty last Query" AND close and relaunch, on relaunch the cursor will be at the beginning of the line for both custom hotkey and Win+R.

I don't know why but even if I use empty last query and close and relaunch, I won't have these issue.

BTW if you have setup the environment, check these lines.

Flow.Launcher/Flow.Launcher/MainWindow.xaml.cs

Lines 157 to 163 in 749e7ff

	case nameof(MainViewModel.QueryTextCursorMovedToEnd):
	if (_viewModel.QueryTextCursorMovedToEnd)
	{
	MoveQueryTextToEnd();
	_viewModel.QueryTextCursorMovedToEnd = false;
	}
	break;

Flow.Launcher/Flow.Launcher/ViewModel/MainViewModel.cs

Lines 343 to 355 in 749e7ff

	public void ChangeQueryText(string queryText, bool reQuery = false)
	{
	if (QueryText != queryText)
	{
	// re-query is done in QueryText's setter method
	QueryText = queryText;
	}
	else if (reQuery)
	{
	Query();
	}
	QueryTextCursorMovedToEnd = true;
	}

[stax76]

I made a PR into the dev branch, is that correct, or rather master branch?

[taooceros]

I made a PR into the dev branch, is that correct, or rather master branch?

That's correct. Thank you!