Merge pull request #352 from Flow-Launcher/fixUpdateSettingRemove

don't remove setting when updating

Author: jjw24

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -233,7 +233,7 @@ where existingPlugin.Metadata.Version.CompareTo(pluginFromManifest.Version) <
                                 Context.API.GetTranslation("plugin_pluginsmanager_update_title"),
                                 MessageBoxButton.YesNo) == MessageBoxResult.Yes)
                             {
-                                Uninstall(x.PluginExistingMetadata);
+                                Uninstall(x.PluginExistingMetadata, false);
 
                                 var downloadToFilePath = Path.Combine(DataLocation.PluginsDirectory,
                                     $"{x.Name}-{x.NewVersion}.zip");
@@ -414,10 +414,13 @@ internal List<Result> RequestUninstall(string search)
             return Search(results, uninstallSearch);
         }
 
-        private void Uninstall(PluginMetadata plugin)
+        private void Uninstall(PluginMetadata plugin, bool removedSetting = true)
         {
-            PluginManager.Settings.Plugins.Remove(plugin.ID);
-            PluginManager.AllPlugins.RemoveAll(p => p.Metadata.ID == plugin.ID);
+            if (removedSetting)
+            {
+                PluginManager.Settings.Plugins.Remove(plugin.ID);
+                PluginManager.AllPlugins.RemoveAll(p => p.Metadata.ID == plugin.ID);
+            }
 
             // Marked for deletion. Will be deleted on next start up
             using var _ = File.CreateText(Path.Combine(plugin.PluginDirectory, "NeedDelete.txt"));

Plugins/Flow.Launcher.Plugin.PluginsManager/plugin.json

@@ -6,7 +6,7 @@
   "Name": "Plugins Manager",
   "Description": "Management of installing, uninstalling or updating Flow Launcher plugins",
   "Author": "Jeremy Wu",
-  "Version": "1.7.0",
+  "Version": "1.7.1",
   "Language": "csharp",
   "Website": "https://github.com/Flow-Launcher/Flow.Launcher",
   "ExecuteFileName": "Flow.Launcher.Plugin.PluginsManager.dll",