Rename to favicon

Author: Jack251970

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -52,12 +52,12 @@ protected List<Bookmark> LoadBookmarks(string browserDataPath, string name)
             var profileBookmarks = LoadBookmarksFromFile(bookmarkPath, source);
 
             // Load favicons after loading bookmarks
-            if (Main._settings.EnableFavoriteIcons)
+            if (Main._settings.EnableFavicons)
             {
                 var faviconDbPath = Path.Combine(profile, "Favicons");
                 if (File.Exists(faviconDbPath))
                 {
-                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {profileBookmarks.Count} favorite icons cost", () =>
+                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {profileBookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, profileBookmarks);
                     });
@@ -157,7 +157,7 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
 
         try
         {
-            // Since some bookmarks may have same favorite icon id, we need to record them to avoid duplicates
+            // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
             var savedPaths = new ConcurrentDictionary<string, bool>();
 
             // Get favicons based on bookmarks concurrently
@@ -202,7 +202,7 @@ ORDER BY b.width DESC
 
                     var faviconPath = Path.Combine(_faviconCacheDir, $"chromium_{domain}_{iconId}.png");
 
-                    // Filter out duplicate favorite icons
+                    // Filter out duplicate favicons
                     if (savedPaths.TryAdd(faviconPath, true))
                     {
                         SaveBitmapData(imageData, faviconPath);

Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

@@ -78,12 +78,12 @@ protected List<Bookmark> GetBookmarksFromPath(string placesPath)
                 .ToList();
 
             // Load favicons after loading bookmarks
-            if (Main._settings.EnableFavoriteIcons)
+            if (Main._settings.EnableFavicons)
             {
                 var faviconDbPath = Path.Combine(Path.GetDirectoryName(placesPath), "favicons.sqlite");
                 if (File.Exists(faviconDbPath))
                 {
-                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {bookmarks.Count} favorite icons cost", () =>
+                    Main._context.API.StopwatchLogInfo(ClassName, $"Load {bookmarks.Count} favicons cost", () =>
                     {
                         LoadFaviconsFromDb(faviconDbPath, bookmarks);
                     });
@@ -144,7 +144,7 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
 
         try
         {
-            // Since some bookmarks may have same favorite icon id, we need to record them to avoid duplicates
+            // Since some bookmarks may have same favicon id, we need to record them to avoid duplicates
             var savedPaths = new ConcurrentDictionary<string, bool>();
 
             // Get favicons based on bookmarks concurrently
@@ -198,7 +198,7 @@ ORDER BY i.width DESC  -- Select largest icon available
                         faviconPath = Path.Combine(_faviconCacheDir, $"firefox_{domain}.png");
                     }
 
-                    // Filter out duplicate favorite icons
+                    // Filter out duplicate favicons
                     if (savedPaths.TryAdd(faviconPath, true))
                     {
                         SaveBitmapData(imageData, faviconPath);

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Languages/en.xaml

@@ -27,6 +27,6 @@
     <system:String x:Key="flowlauncher_plugin_browserbookmark_browserEngine">Browser Engine</system:String>
     <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage01">If you are not using Chrome, Firefox or Edge, or you are using their portable version, you need to add bookmarks data directory and select correct browser engine to make this plugin work.</system:String>
     <system:String x:Key="flowlauncher_plugin_browserbookmark_guideMessage02">For example: Brave's engine is Chromium; and its default bookmarks data location is: "%LOCALAPPDATA%\BraveSoftware\Brave-Browser\UserData". For Firefox engine, the bookmarks directory is the userdata folder contains the places.sqlite file.</system:String>
-    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favorite_icons">Load favicons (can be time consuming during startup)</system:String>
+    <system:String x:Key="flowlauncher_plugin_browserbookmark_enable_favicons">Load favicons (can be time consuming during startup)</system:String>
 
 </ResourceDictionary>

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Models/Settings.cs

@@ -8,7 +8,7 @@ public class Settings : BaseModel
 
     public string BrowserPath { get; set; }
 
-    public bool EnableFavoriteIcons { get; set; } = false;
+    public bool EnableFavicons { get; set; } = false;
 
     public bool LoadChromeBookmark { get; set; } = true;
     public bool LoadFirefoxBookmark { get; set; } = true;

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Views/SettingsControl.xaml

@@ -97,7 +97,7 @@
             Margin="{StaticResource SettingPanelItemTopBottomMargin}"
             HorizontalAlignment="Left"
             VerticalAlignment="Center"
-            Content="{DynamicResource flowlauncher_plugin_browserbookmark_enable_favorite_icons}"
-            IsChecked="{Binding Settings.EnableFavoriteIcons}" />
+            Content="{DynamicResource flowlauncher_plugin_browserbookmark_enable_favicons}"
+            IsChecked="{Binding Settings.EnableFavicons}" />
     </Grid>
 </UserControl>