review feedback

Author: dcog989

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs

@@ -67,7 +67,7 @@ private string SetupTempDirectory()
     public List<Result> Query(Query query)
     {
         var search = query.Search.Trim();
-        var bookmarks = _bookmarks; // use a local copy
+        var bookmarks = Volatile.Read(ref _bookmarks); // use a local copy with proper memory barrier
 
         if (!string.IsNullOrEmpty(search))
         {

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/ChromiumBookmarkLoader.cs

@@ -55,10 +55,22 @@ public async IAsyncEnumerable<Bookmark> GetBookmarksAsync([EnumeratorCancellatio
                     bookmarks.AddRange(EnumerateBookmarks(rootElement, source, profilePath));
                 }
             }
+            catch (IOException ex)
+            {
+                _logException(nameof(ChromiumBookmarkLoader), $"IO error reading {_browserName} bookmarks: {bookmarkPath}", ex);
+            }
+            catch (UnauthorizedAccessException ex)
+            {
+                _logException(nameof(ChromiumBookmarkLoader), $"Unauthorized to read {_browserName} bookmarks: {bookmarkPath}", ex);
+            }
             catch (JsonException ex)
             {
                 _logException(nameof(ChromiumBookmarkLoader), $"Failed to parse bookmarks file for {_browserName}: {bookmarkPath}", ex);
             }
+            catch (Exception ex)
+            {
+                _logException(nameof(ChromiumBookmarkLoader), $"Unexpected error loading {_browserName} bookmarks: {bookmarkPath}", ex);
+            }
 
             foreach (var bookmark in bookmarks)
             {

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FaviconService.cs

@@ -240,11 +240,15 @@ private static string GetCachePath(string url, string cacheDir)
 
     private static FetchResult SelectBestFavicon(FetchResult icoResult, FetchResult htmlResult)
     {
-        if (htmlResult.Size >= ImageConverter.TargetIconSize) return htmlResult;
-        if (icoResult.Size >= ImageConverter.TargetIconSize) return icoResult;
-        if (htmlResult.Size > icoResult.Size) return htmlResult;
-        if (icoResult.Size >= 0) return icoResult;
-        if (htmlResult.Size >= 0) return htmlResult;
+        var htmlValid = htmlResult.PngData != null;
+        var icoValid  = icoResult.PngData  != null;
+
+        if (htmlValid && htmlResult.Size >= ImageConverter.TargetIconSize) return htmlResult;
+        if (icoValid  && icoResult.Size  >= ImageConverter.TargetIconSize) return icoResult;
+
+        if (htmlValid && icoValid) return htmlResult.Size >= icoResult.Size ? htmlResult : icoResult;
+        if (htmlValid) return htmlResult;
+        if (icoValid)  return icoResult;
         return default;
     }
 

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FaviconWebClient.cs

@@ -46,9 +46,9 @@ public FaviconWebClient(PluginInitContext context)
             var buffer = new char[4096];
             int charsRead;
             var totalCharsRead = 0;
-            const int maxCharsToRead = 500 * 1024;
+            const int maxHeadChars = 150 * 1024;
 
-            while (!token.IsCancellationRequested && (charsRead = await reader.ReadAsync(buffer, 0, buffer.Length)) > 0 && totalCharsRead < maxCharsToRead)
+            while (!token.IsCancellationRequested && (charsRead = await reader.ReadAsync(buffer, 0, buffer.Length)) > 0 && totalCharsRead < maxHeadChars)
             {
                 contentBuilder.Append(buffer, 0, charsRead);
                 totalCharsRead += charsRead;

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FirefoxBookmarkLoader.cs

@@ -57,7 +57,15 @@ public async IAsyncEnumerable<Bookmark> GetBookmarksAsync([EnumeratorCancellatio
             try
             {
                 tempDbPath = Path.Combine(_tempPath, $"ff_places_{Guid.NewGuid()}.sqlite");
+                var walPath = _placesPath + "-wal";
+                var shmPath = _placesPath + "-shm";
+
                 File.Copy(_placesPath, tempDbPath, true);
+                if (File.Exists(walPath))
+                    File.Copy(walPath, tempDbPath + "-wal", true);
+                if (File.Exists(shmPath))
+                    File.Copy(shmPath, tempDbPath + "-shm", true);
+
                 await ReadBookmarksFromDb(tempDbPath, bookmarks, cancellationToken);
             }
             catch (Exception copyEx)

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/LocalFaviconExtractor.cs

@@ -22,11 +22,19 @@ public LocalFaviconExtractor(PluginInitContext context, string tempPath)
 
     public async Task<byte[]?> GetFaviconDataAsync(Bookmark bookmark, CancellationToken token)
     {
-        return bookmark.Source switch
+        var profilePath = bookmark.ProfilePath;
+        if (!string.IsNullOrEmpty(profilePath))
         {
-            var s when s.Contains("Firefox") => await GetFirefoxFaviconAsync(bookmark, token),
-            _ => await GetChromiumFaviconAsync(bookmark, token) // Default to Chromium
-        };
+            if (File.Exists(Path.Combine(profilePath, "favicons.sqlite")))
+                return await GetFirefoxFaviconAsync(bookmark, token);
+
+            if (File.Exists(Path.Combine(profilePath, "Favicons")))
+                return await GetChromiumFaviconAsync(bookmark, token);
+        }
+
+        return bookmark.Source?.IndexOf("Firefox", StringComparison.OrdinalIgnoreCase) >= 0
+            ? await GetFirefoxFaviconAsync(bookmark, token)
+            : await GetChromiumFaviconAsync(bookmark, token);
     }
 
     private Task<byte[]?> GetChromiumFaviconAsync(Bookmark bookmark, CancellationToken token)