Move WMP check to app startup

Author: VictoriousRaptor

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -271,6 +271,9 @@ public bool HideNotifyIcon
         public AnimationSpeeds AnimationSpeed { get; set; } = AnimationSpeeds.Medium;
         public int CustomAnimationLength { get; set; } = 360;
 
+        [JsonIgnore]
+        public bool WMPInstalled { get; set; } = true;
+
 
         // This needs to be loaded last by staying at the bottom
         public PluginsSettings PluginSettings { get; set; } = new PluginsSettings();

Flow.Launcher/App.xaml.cs

@@ -62,6 +62,7 @@ await Stopwatch.NormalAsync("|App.OnStartup|Startup cost", async () =>
 
                 _settingsVM = new SettingWindowViewModel(_updater, _portable);
                 _settings = _settingsVM.Settings;
+                _settings.WMPInstalled =  WindowsMediaPlayerHelper.IsWindowsMediaPlayerInstalled();
 
                 AbstractPluginEnvironment.PreStartPluginExecutablePathUpdate(_settings);
 

Flow.Launcher/MainWindow.xaml.cs

@@ -46,7 +46,6 @@ public partial class MainWindow
         private bool _animating;
         private bool isArrowKeyPressed = false;
 
-        private bool isWMPInstalled = true;
         private MediaPlayer animationSoundWMP;
         private SoundPlayer animationSoundWPF;
 
@@ -509,8 +508,7 @@ public void WindowAnimator()
 
         private void InitSoundEffects()
         {
-            isWMPInstalled = WindowsMediaPlayerHelper.IsWindowsMediaPlayerInstalled();
-            if (isWMPInstalled)
+            if (_settings.WMPInstalled)
             {
                 animationSoundWMP = new MediaPlayer();
                 animationSoundWMP.Open(new Uri(AppDomain.CurrentDomain.BaseDirectory + "Resources\\open.wav"));
@@ -523,8 +521,7 @@ private void InitSoundEffects()
 
         private void SoundPlay()
         {
-
-            if (isWMPInstalled)
+            if (_settings.WMPInstalled)
             {
                 animationSoundWMP.Position = TimeSpan.Zero;
                 animationSoundWMP.Volume = _settings.SoundVolume / 100.0;

Flow.Launcher/SettingWindow.xaml.cs

@@ -67,7 +67,7 @@ private void OnLoaded(object sender, RoutedEventArgs e)
 
         private void CheckMediaPlayer()
         {
-            if (!WindowsMediaPlayerHelper.IsWindowsMediaPlayerInstalled())
+            if (settings.WMPInstalled)
             {
                 WMPWarning.Visibility = Visibility.Visible;
                 VolumeAdjustCard.Visibility = Visibility.Collapsed;