Skip to content

Conversation

@oscardssmith
Copy link
Collaborator

JuliaLang/julia#58131 unifies the method table, so this is necessary to make Enzyme precompile on 1.12.

Should we do something to make sure CI succeeds in loading Enzyme on 1.12? (even if we don't expect tests to pass).

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.06%. Comparing base (037dfed) to head (a6ca5d4).
⚠️ Report is 447 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/jitrules.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
+ Coverage   67.50%   75.06%   +7.55%     
==========================================
  Files          31       56      +25     
  Lines       12668    17306    +4638     
==========================================
+ Hits         8552    12990    +4438     
- Misses       4116     4316     +200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses
Copy link
Member

wsmoses commented Jul 31, 2025

yeah completely agreed

@wsmoses wsmoses merged commit afb9f1d into EnzymeAD:main Jul 31, 2025
26 of 31 checks passed
@oscardssmith oscardssmith deleted the os/fix-1.12-compile branch July 31, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants