Make common sql executor #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipovartem
commented
Feb 7, 2025
osipovartem
requested review from
DanCodedThis,
Vedin,
YaroslavLitvinov,
eadgbear and
rampage644
Vedin
approved these changes
Feb 7, 2025
Contributor
Vedin
left a comment
Vedin
left a comment
There was a problem hiding this comment.
lgtm. Do we use upload_data_to_table only for CSV now?
Contributor
Author
Yes, only for CSV |
DanCodedThis
approved these changes
Feb 7, 2025
osipovartem
temporarily deployed
to
production
GitHub Actions
Inactive
osipovartem
added a commit
that referenced
this pull request
Feb 7, 2025
# This is the 1st commit message: Make common sql executor Make common sql executor Alter session params to current context Make common sql executor (#209) * Make common sql executor * Make common sql executor # This is the commit message #2: Fix deployment (#211) * Fix deployment * Fix binary name # This is the commit message #3: Fix tmp EOF until fix released # This is the commit message #4: Register CSV within current context # This is the commit message #5: Register CSV within current context
osipovartem
added a commit
that referenced
this pull request
Feb 7, 2025
* # This is a combination of 5 commits. # This is the 1st commit message: Make common sql executor Make common sql executor Alter session params to current context Make common sql executor (#209) * Make common sql executor * Make common sql executor # This is the commit message #2: Fix deployment (#211) * Fix deployment * Fix binary name # This is the commit message #3: Fix tmp EOF until fix released # This is the commit message #4: Register CSV within current context # This is the commit message #5: Register CSV within current context * Register CSV within current context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #130