Skip to content

Commit 6259d76

Browse files
committed
Fixes after rebase
1 parent ecc5bb9 commit 6259d76

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

crates/metastore/src/models/schema.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ impl SchemaIdent {
4040
}
4141
}
4242

43-
impl std::fmt::Display for IceBucketSchemaIdent {
43+
impl std::fmt::Display for SchemaIdent {
4444
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
4545
write!(f, "{}.{}", self.database, self.schema)
4646
}

crates/runtime/src/execution/query.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,14 @@ use datafusion_expr::CreateMemoryTable;
3838
use datafusion_expr::DdlStatement;
3939
use datafusion_iceberg::catalog::catalog::IcebergCatalog;
4040
use embucket_metastore::{
41-
Metastore, Schema as MetastoreSchema, SchemaIdent as MetastoreSchemaIdent,
41+
Metastore, SchemaIdent as MetastoreSchemaIdent,
4242
TableCreateRequest as MetastoreTableCreateRequest, TableFormat as MetastoreTableFormat,
4343
TableIdent as MetastoreTableIdent,
4444
};
4545
use iceberg_rust::catalog::create::CreateTableBuilder;
4646
use iceberg_rust::catalog::Catalog;
4747
use iceberg_rust::spec::arrow::schema::new_fields_with_ids;
48+
use iceberg_rust::spec::namespace::Namespace;
4849
use iceberg_rust::spec::schema::Schema;
4950
use iceberg_rust::spec::types::StructType;
5051
use object_store::aws::AmazonS3Builder;

crates/runtime/src/execution/tests/query.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,13 +378,13 @@ async fn test_drop_table() {
378378
#[tokio::test]
379379
async fn test_create_schema() {
380380
let (execution_svc, metastore, session_id) = prepare_env().await;
381-
let schema_ident = IceBucketSchemaIdent {
382-
database: "icebucket".to_string(),
381+
let schema_ident = MetastoreSchemaIdent {
382+
database: "embucket".to_string(),
383383
schema: "public_new".to_string(),
384384
};
385385
let query = format!("CREATE SCHEMA {schema_ident};");
386386
execution_svc
387-
.query(&session_id, &query, IceBucketQueryContext::default())
387+
.query(&session_id, &query, QueryContext::default())
388388
.await
389389
.expect("Failed to execute query");
390390
// TODO use "SHOW SCHEMAS" sql

crates/runtime/src/execution/utils.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ use chrono::DateTime;
2828
use datafusion::arrow::array::ArrayRef;
2929
use datafusion::arrow::datatypes::DataType;
3030
use datafusion::common::Result as DataFusionResult;
31+
use embucket_metastore::SchemaIdent as MetastoreSchemaIdent;
3132
use embucket_metastore::TableIdent as MetastoreTableIdent;
3233
use sqlparser::ast::{Ident, ObjectName};
3334
use std::collections::HashMap;
@@ -393,7 +394,7 @@ impl From<NormalizedIdent> for MetastoreTableIdent {
393394
}
394395
}
395396

396-
impl From<NormalizedIdent> for IceBucketSchemaIdent {
397+
impl From<NormalizedIdent> for MetastoreSchemaIdent {
397398
fn from(ident: NormalizedIdent) -> Self {
398399
let ident = ident.0;
399400
Self {

0 commit comments

Comments
 (0)