Skip to content

Commit 22b713d

Browse files
committed
plugins: remove allowance for missing JSON id in commando.
Changelog-Removed: Plugins: no longer allow missing `id` field in commando requests (deprecated v23.02, EOL v24.02) Signed-off-by: Rusty Russell <[email protected]>
1 parent 9960454 commit 22b713d

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

doc/developers-guide/deprecations.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ hidden: false
3333
| estimatefees.penalty | Field | v23.05 | v24.05 | `penalty` feerate (implementation-specific, use modern feerates) |
3434
| estimatefees.min_acceptable | Field | v23.05 | v24.05 | `min_acceptable` feerate (implementation-specific, use modern feerates) |
3535
| estimatefees.max_acceptable | Field | v23.05 | v24.05 | `max_acceptable` feerate (implementation-specific, use modern feerates) |
36-
| commando.missing_id | Parameter | v23.02 | v24.02 | Incoming JSON commands without an `id` field |
3736
| offer.recurrence_base.at_prefix | Parameter | v24.02 | v24.05 | `recurrence_base` with `@` prefix (use `recurrence_start_any_period`) |
3837

3938

plugins/commando.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,7 @@ static void try_command(struct commando *incoming STEALS)
397397
}
398398
filter = json_get_member(buf, toks, "filter");
399399
id = json_get_member(buf, toks, "id");
400-
if (!id && !command_deprecated_in_nocmd_ok(plugin, "commando.missing-id",
401-
"v23.02", "v24.02")) {
400+
if (!id) {
402401
commando_error(incoming, COMMANDO_ERROR_REMOTE,
403402
"missing id field");
404403
return;

0 commit comments

Comments
 (0)