From eec5ffeb8d0cb072f01495fae66bed7d4295df17 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 6 Feb 2021 16:54:35 -0800 Subject: [PATCH 1/3] Remove redundant tool dependency installation step from CI workflow The arduino/actions/libraried/compile-examples action's installation of the electroniccats:mbed package via Boards Manager installs the platform's tools dependencies, so it's not necessary to do this separately. --- .github/workflows/compile-examples.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 499374988..4ffd53246 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -46,14 +46,6 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v2 - - - name: Setup Python - uses: actions/setup-python@v1 - with: - python-version: '3.x' - - - name: Install nrfutil - run: pip3 install adafruit-nrfutil # The source files are in a subfolder of the ArduinoCore-API repository, so it's not possible to clone it directly to the final destination in the core - name: Checkout ArduinoCore-API From 209e9f074d7a3ad58b2909a50fc3800ae2f1a8af Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 6 Feb 2021 16:57:03 -0800 Subject: [PATCH 2/3] Remove ArduinoCore-API installation from CI workflow Unlike the arduino:mbed platform, this repository contains a bundled copy of ArduinoCore-API, so there is no need for the workflow to do it. --- .github/workflows/compile-examples.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 4ffd53246..329836a38 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -47,19 +47,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v2 - # The source files are in a subfolder of the ArduinoCore-API repository, so it's not possible to clone it directly to the final destination in the core - - name: Checkout ArduinoCore-API - uses: actions/checkout@v2 - with: - repository: arduino/ArduinoCore-API - path: ArduinoCore-API - - - name: Remove old symlink to api - run: rm -rf "$GITHUB_WORKSPACE/cores/arduino/api" - - - name: Install ArduinoCore-API - run: mv "$GITHUB_WORKSPACE/ArduinoCore-API/api" "$GITHUB_WORKSPACE/cores/arduino" - - name: Compile examples uses: arduino/actions/libraries/compile-examples@master with: From 8097926b621c968bf4d35cf965c28c6bc8f78fe9 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 6 Feb 2021 17:03:52 -0800 Subject: [PATCH 3/3] Remove redundant platform dependency definition There were two electroniccats:mbed platform dependency definitions listed in the arduino/actions/libraries/compile-examples action's platforms input. The one that specifies the package index URL is the complete one and the other is unnecessary. --- .github/workflows/compile-examples.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 329836a38..1eb88d248 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -52,10 +52,9 @@ jobs: with: fqbn: ${{ matrix.board.fqbn }} platforms: | + # Use Board Manager to install the latest release of Arduino mbed Boards to get the toolchain - source-url: "https://electroniccats.github.io/Arduino_Boards_Index/package_electroniccats_index.json" name: "electroniccats:mbed" - # Use Board Manager to install the latest release of Arduino mbed Boards to get the toolchain - - name: "electroniccats:mbed" # Overwrite the Board Manager installation with the local platform - source-path: "./" name: "electroniccats:mbed"