Merge pull request #613 from aguang-xyz/fix/npe-when-target-not-specified

robertmuehsig · web-flow · commit 0ef5edfdf6fc · 2022-02-21T22:55:01.000+01:00
Fix IndexOutOfRangeException in build command parsing logic
diff --git a/ElectronNET.CLI/Commands/BuildCommand.cs b/ElectronNET.CLI/Commands/BuildCommand.cs
@@ -62,7 +62,7 @@ public Task<bool> ExecuteAsync()
                 if (parser.Arguments.ContainsKey(_paramVersion))
                     version = parser.Arguments[_paramVersion][0];
 
-                if (!parser.Arguments.ContainsKey(_paramTarget))
+                if (!parser.Arguments.ContainsKey(_paramTarget) || parser.Arguments[_paramTarget].Length == 0)
                 {
                     Console.WriteLine($"Error: missing '{_paramTarget}' argument.");
                     Console.WriteLine(COMMAND_ARGUMENTS);

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public Task<bool> ExecuteAsync()`
`62`	`62`	`if (parser.Arguments.ContainsKey(_paramVersion))`
`63`	`63`	`version = parser.Arguments[_paramVersion][0];`
`64`	`64`
`65`		`- if (!parser.Arguments.ContainsKey(_paramTarget))`
	`65`	`+ if (!parser.Arguments.ContainsKey(_paramTarget) \|\| parser.Arguments[_paramTarget].Length == 0)`
`66`	`66`	`{`
`67`	`67`	`Console.WriteLine($"Error: missing '{_paramTarget}' argument.");`
`68`	`68`	`Console.WriteLine(COMMAND_ARGUMENTS);`