enable mounting previous overlay-upper read-only #550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
|
Instance
|
ocaisa
requested changes
May 15, 2024
Comment on lines
+612
to
+613
| # make sure the overlay-upper directory exists | ||
| mkdir -p ${EESSI_TMPDIR}/overlay-upper |
Member
There was a problem hiding this comment.
Isn't this redundant, you've checked the directory exists to enter this block
Collaborator
|
Closed in favour of #674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case for this is that we want to test software additions to a CernVM-FS repository. Typically we would first run
eessi_container.shwith--access rwto make the repository writable with an overlayfs. The changes are stored in someoverlay-upperdirectory (under some/tmpdir or in a tarball of that/tmpdirectory). When we want to test the additions later we can runeessi_container.shwith--resume TMPDIR_OR_TMPTARBALL. However, until now this only worked when using--access rwwhich would make the repository again writable, which is likely not what is wanted in a test (because in actual use/cvmfs/*mounts are read-only). In fact, thetest-suite.shrun after a build job has finished, uses--access ro(read-only), but this access mode did not recognise changes in anoverlay-upperdirectory.This PR merges an existing
overlay-upper(given via--resume ...) on top of a CernVM-FS repository. Because it only uses thelowerdiroption offuse-overlayfsthe merged directory is mounted read-only.