Skip to content

{2023.06}[2023a] Highway v1.0.4 #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 4, 2024
Merged

{2023.06}[2023a] Highway v1.0.4 #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
542022c
add hook that disables tests for Highway 1.0.4 on neoverse_v1
bedroge Apr 3, 2024
a770536
add Highway-1.0.4-GCCcore-12.3.0.eb
bedroge Apr 3, 2024
3cc125d
add known issue about Highway 1.0.4 on neoverse_v1
bedroge Apr 3, 2024
098d525
Update eb_hooks.py
ocaisa Apr 3, 2024
10e1d00
fix syntax, remove (
bedroge Apr 3, 2024
941aa2a
Merge branch 'highway_1.0.4_gcccore_12.3.0' of github.com:bedroge/sof…
bedroge Apr 3, 2024
abfe1bf
add toolchain and version check to Highway hook that disables the tests
bedroge Apr 3, 2024
ae74707
syntax fix
bedroge Apr 3, 2024
92aad04
also disable Highway 1.0.4 tests for neoverse_n1
bedroge Apr 3, 2024
f2954ef
oops, changed the wrong hook... fixed
bedroge Apr 3, 2024
11b7bc2
different actions for neoverse_n1 and _v1 in highway hook
bedroge Apr 3, 2024
69d0e9d
update docstring of parse_hook_highway_handle_test_compilation_issues
bedroge Apr 4, 2024
7dba052
add issue with Highway 1.0.4 on neoverse_n1
bedroge Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023a.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,4 @@ easyconfigs:
from-pr: 20126
- OpenJPEG-2.5.0-GCCcore-12.3.0.eb
- OpenFOAM-10-foss-2023a.eb
- Highway-1.0.4-GCCcore-12.3.0.eb
24 changes: 23 additions & 1 deletion eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from distutils.version import LooseVersion


CPU_TARGET_NEOVERSE_N1 = 'aarch64/neoverse_n1'
CPU_TARGET_NEOVERSE_V1 = 'aarch64/neoverse_v1'
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'

Expand Down Expand Up @@ -289,6 +290,26 @@ def parse_hook_lammps_remove_deps_for_CI_aarch64(ec, *args, **kwargs):
raise EasyBuildError("LAMMPS-specific hook triggered for non-LAMMPS easyconfig?!")


def parse_hook_highway_handle_test_compilation_issues(ec, eprefix):
"""
Solve issues with compiling or running the tests on both
neoverse_n1 and neoverse_v1 with Highway 1.0.4 and GCC 12.3.0:
- for neoverse_n1 we set optarch to GENERIC
- for neoverse_v1 we completely disable the tests
cfr. https://github.com/EESSI/software-layer/issues/469
"""
if ec.name == 'Highway':
tcname, tcversion = ec['toolchain']['name'], ec['toolchain']['version']
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if ec.version in ['1.0.4'] and tcname == 'GCCcore' and tcversion == '12.3.0':
if cpu_target == CPU_TARGET_NEOVERSE_V1:
ec.update('configopts', '-DHWY_ENABLE_TESTS=OFF')
if cpu_target == CPU_TARGET_NEOVERSE_N1:
update_build_option('optarch', OPTARCH_GENERIC)
Copy link
Contributor

@boegel boegel Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, we have to be more careful here...

optarch is a general build option here, which is set for the entire EasyBuild session in which Highway and all missing dependencies are installed, so it's not specific to Highway at all. 🚨

For this particular build, it was fine because all dependencies of Highway were already in place.

Copy link
Contributor

@boegel boegel Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use update_build_option in the hook for numpy too, but we later revert back to the original value (see post_single_extension_numpy).

else:
raise EasyBuildError("Highway-specific hook triggered for non-Highway easyconfig?!")


def pre_configure_hook(self, *args, **kwargs):
"""Main pre-configure hook: trigger custom functions based on software name."""
if self.name in PRE_CONFIGURE_HOOKS:
Expand Down Expand Up @@ -608,11 +629,12 @@ def inject_gpu_property(ec):
'casacore': parse_hook_casacore_disable_vectorize,
'CGAL': parse_hook_cgal_toolchainopts_precise,
'fontconfig': parse_hook_fontconfig_add_fonts,
'Highway': parse_hook_highway_handle_test_compilation_issues,
'LAMMPS': parse_hook_lammps_remove_deps_for_CI_aarch64,
'OpenBLAS': parse_hook_openblas_relax_lapack_tests_num_errors,
'pybind11': parse_hook_pybind11_replace_catch2,
'Qt5': parse_hook_qt5_check_qtwebengine_disable,
'UCX': parse_hook_ucx_eprefix,
'LAMMPS': parse_hook_lammps_remove_deps_for_CI_aarch64,
}

POST_PREPARE_HOOKS = {
Expand Down
6 changes: 6 additions & 0 deletions eessi-2023.06-known-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "8 failing tests (out of 209539) on aarch64/*"
- aarch64/neoverse_n1:
- Highway-1.0.4-GCCcore-12.3.0.eb:
- issue: https://github.com/EESSI/software-layer/issues/469
- info: "failing to build the tests"
- PyTorch-2.1.2-foss-2023a:
- issue: https://github.com/EESSI/software-layer/issues/461
- info: "8 failing tests (out of 209539) on aarch64/*"
Expand All @@ -19,6 +22,9 @@
- Highway-1.0.3-GCCcore-12.2.0.eb:
- issue: https://github.com/EESSI/software-layer/issues/469
- info: "failing SVE test due to wrong expected value"
- Highway-1.0.4-GCCcore-12.3.0.eb:
- issue: https://github.com/EESSI/software-layer/issues/469
- info: "failing to build the tests"
- netCDF-4.9.2-gompi-2023a.eb:
- issue: https://github.com/EESSI/software-layer/issues/425
- info: "netCDF intermittent test failures"
Expand Down