Skip to content

Conversation

@bedroge
Copy link
Collaborator

@bedroge bedroge commented Dec 19, 2023

This sets/overrides $EESSI_CPU_FAMILY to the part before the first slash of $EESSI_SOFTWARE_SUBDIR_OVERRIDE, as it's otherwise always set to the architecture of the runner (i.e. x86_64). This causes issues with checks in our EB configuration that use $EESSI_CPU_FAMILY, e.g. for filtering dependencies for aarch64 CPUs, which in turn cause the CI to fail for these architectures. This just happened in #432 .

@eessi-bot
Copy link

eessi-bot bot commented Dec 19, 2023

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

@bedroge bedroge requested a review from boegel December 19, 2023 14:53
@ocaisa
Copy link
Member

ocaisa commented Dec 19, 2023

I was just about to make the same PR. Shouldn't you also do it in the second instance below this line (line 58)? I know it has no practical consequence but since you know it's a potential issue, might as well keep it consistent

@bedroge
Copy link
Collaborator Author

bedroge commented Dec 19, 2023

I was just about to make the same PR. Shouldn't you also do it in the second instance below this line (line 58)? I know it has no practical consequence but since you know it's a potential issue, might as well keep it consistent

Ah, thanks, overlooked that one. May not be strictly necessary (as it only checks GCC), but I've added it anyway.

@ocaisa ocaisa merged commit 4267fe9 into EESSI:2023.06-software.eessi.io Dec 19, 2023
@bedroge bedroge deleted the fix_aarch64_ci branch December 19, 2023 15:05
@boegel boegel added 2023.06-software.eessi.io 2023.06 version of software.eessi.io bug Something isn't working labels Jan 11, 2024
TopRichard added a commit to TopRichard/software-layer that referenced this pull request Jul 23, 2024
…ealpath2

Use readlink -f instead of realpath (CentOS6)2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2023.06-software.eessi.io 2023.06 version of software.eessi.io bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants