-
Notifications
You must be signed in to change notification settings - Fork 66
Add support in archdetect for detecting NVIDIA/Grace #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in archdetect for detecting NVIDIA/Grace #1042
Conversation
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
…ftware-layer into eessi-2023.06-grace-Add-support-in-archdetect-for-detecting-NVIDIA/Grace
Co-authored-by: Kenneth Hoste <[email protected]>
…e is also actually used by updating Google Actions workflow
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TopRichard The extra test case for nvidia/grace is only used when the corresponding GitHub Actions workflow is also updated.
Also, it's worth also adding a test case for google/axion.
Both tackled in TopRichard#17
…are-layer into eessi-2023.06-grace-Add-support-in-archdetect-for-detecting-NVIDIA/Grace
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go for me now.
@trz42 Can you double check, and perhaps manually test on both grace and axion?
Should be fine though, since it's verified through the extra test cases.
We'll also need to trigger a deploy before merging.
Works on Google Axion [@google-axion software-layer]$ cat /proc/cpuinfo | awk '/^processor/{p++} p==1' && init/eessi_archdetect.sh -a cpupath
processor : 0
BogoMIPS : 2000.00
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm ssbs sb dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd4f
CPU revision : 1
aarch64/google/axion:aarch64/nvidia/grace:aarch64/neoverse_v1:aarch64/neoverse_n1:aarch64/genericand also on NVIDIA Grace/Hopper [jrc0900 software-layer]$ cat /proc/cpuinfo | awk '/^processor/{p++} p==1' && init/eessi_archdetect.sh -a cpupath
processor : 0
BogoMIPS : 2000.00
Features : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm ssbs sb dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh
CPU implementer : 0x41
CPU architecture: 8
CPU variant : 0x0
CPU part : 0xd4f
CPU revision : 0
aarch64/nvidia/grace:aarch64/neoverse_v1:aarch64/neoverse_n1:aarch64/generic |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
Label |
|
New job on instance
|
bedroge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the tarball includes eb_hooks.py as we forgot to deploy that in #1046.
|
Label |
|
Tarball has been ingested. |
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
This PR should not be merged until NVIDIA/Grace stack is ready