Skip to content

Commit a3484da

Browse files
authored
Merge pull request #725 from laraPPr/LAMMPS
{2023.06}[foss/2023b] LAMMPS 29Aug2024
2 parents 34ab6de + abbbf35 commit a3484da

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
easyconfigs:
2+
- LAMMPS-29Aug2024-foss-2023b-kokkos.eb:
3+
# see https://github.com/easybuilders/easybuild-easyconfigs/pull/21436
4+
options:
5+
from-commit: 9dc24e57880a8adb06ae10557c5315e66671a533

eb_hooks.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -301,19 +301,20 @@ def parse_hook_ucx_eprefix(ec, eprefix):
301301
raise EasyBuildError("UCX-specific hook triggered for non-UCX easyconfig?!")
302302

303303

304-
def parse_hook_lammps_remove_deps_for_CI_aarch64(ec, *args, **kwargs):
304+
def parse_hook_lammps_remove_deps_for_aarch64(ec, *args, **kwargs):
305305
"""
306-
Remove x86_64 specific dependencies for the CI to pass on aarch64
306+
Remove x86_64 specific dependencies for the CI and missing installations to pass on aarch64
307307
"""
308-
if ec.name == 'LAMMPS' and ec.version in ('2Aug2023_update2',):
309-
if os.getenv('EESSI_CPU_FAMILY') == 'aarch64':
310-
# ScaFaCoS and tbb are not compatible with aarch64/* CPU targets,
311-
# so remove them as dependencies for LAMMPS (they're optional);
312-
# see also https://github.com/easybuilders/easybuild-easyconfigs/pull/19164 +
313-
# https://github.com/easybuilders/easybuild-easyconfigs/pull/19000;
314-
# we need this hook because we check for missing installations for all CPU targets
315-
# on an x86_64 VM in GitHub Actions (so condition based on ARCH in LAMMPS easyconfig is always true)
316-
ec['dependencies'] = [dep for dep in ec['dependencies'] if dep[0] not in ('ScaFaCoS', 'tbb')]
308+
if ec.name == 'LAMMPS':
309+
if ec.version in ('2Aug2023_update2', '29Aug2024'):
310+
if os.getenv('EESSI_CPU_FAMILY') == 'aarch64':
311+
# ScaFaCoS and tbb are not compatible with aarch64/* CPU targets,
312+
# so remove them as dependencies for LAMMPS (they're optional);
313+
# see also https://github.com/easybuilders/easybuild-easyconfigs/pull/19164 +
314+
# https://github.com/easybuilders/easybuild-easyconfigs/pull/19000;
315+
# we need this hook because we check for missing installations for all CPU targets
316+
# on an x86_64 VM in GitHub Actions (so condition based on ARCH in LAMMPS easyconfig is always true)
317+
ec['dependencies'] = [dep for dep in ec['dependencies'] if dep[0] not in ('ScaFaCoS', 'tbb',)]
317318
else:
318319
raise EasyBuildError("LAMMPS-specific hook triggered for non-LAMMPS easyconfig?!")
319320

@@ -537,7 +538,7 @@ def pre_configure_hook_LAMMPS_zen4(self, *args, **kwargs):
537538

538539
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
539540
if self.name == 'LAMMPS':
540-
if self.version == '2Aug2023_update2':
541+
if self.version in ('2Aug2023_update2', '29Aug2024'):
541542
if get_cpu_architecture() == X86_64:
542543
if cpu_target == CPU_TARGET_ZEN4:
543544
# There is no support for ZEN4 in LAMMPS yet so falling back to ZEN3
@@ -803,7 +804,7 @@ def inject_gpu_property(ec):
803804
'CGAL': parse_hook_cgal_toolchainopts_precise,
804805
'fontconfig': parse_hook_fontconfig_add_fonts,
805806
'grpcio': parse_hook_grpcio_zlib,
806-
'LAMMPS': parse_hook_lammps_remove_deps_for_CI_aarch64,
807+
'LAMMPS': parse_hook_lammps_remove_deps_for_aarch64,
807808
'CP2K': parse_hook_CP2K_remove_deps_for_aarch64,
808809
'OpenBLAS': parse_hook_openblas_relax_lapack_tests_num_errors,
809810
'pybind11': parse_hook_pybind11_replace_catch2,

0 commit comments

Comments
 (0)