Skip to content

Commit 6fee4c9

Browse files
authored
Merge pull request #479 from t1mk1k/new_pr_wsclean_dp3_2023b
{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0
2 parents 8fc3fc4 + 790756b commit 6fee4c9

File tree

2 files changed

+63
-4
lines changed

2 files changed

+63
-4
lines changed

easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,38 @@ easyconfigs:
88
- matplotlib-3.8.2-gfbf-2023b.eb:
99
options:
1010
from-pr: 19552
11+
- AOFlagger-3.4.0-foss-2023b.eb:
12+
options:
13+
from-pr: 19840
14+
include-easyblocks-from-pr: 3088
15+
- arpack-ng-3.9.0-foss-2023b.eb:
16+
options:
17+
from-pr: 19840
18+
include-easyblocks-from-pr: 3088
19+
- Armadillo-12.8.0-foss-2023b.eb:
20+
options:
21+
from-pr: 19840
22+
include-easyblocks-from-pr: 3088
23+
- casacore-3.5.0-foss-2023b.eb:
24+
options:
25+
from-pr: 19840
26+
include-easyblocks-from-pr: 3088
27+
- IDG-1.2.0-foss-2023b.eb:
28+
options:
29+
from-pr: 19840
30+
include-easyblocks-from-pr: 3088
31+
- EveryBeam-0.5.2-foss-2023b.eb:
32+
options:
33+
from-pr: 19840
34+
include-easyblocks-from-pr: 3088
35+
- DP3-6.0-foss-2023b.eb:
36+
options:
37+
from-pr: 19840
38+
include-easyblocks-from-pr: 3088
39+
- WSClean-3.4-foss-2023b.eb:
40+
options:
41+
from-pr: 19840
42+
include-easyblocks-from-pr: 3088
1143
- CDO-2.2.2-gompi-2023b.eb:
1244
options:
13-
from-pr: 19792
45+
from-pr: 19792

eb_hooks.py

Lines changed: 30 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222

2323
CPU_TARGET_NEOVERSE_V1 = 'aarch64/neoverse_v1'
24-
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'
24+
CPU_TARGET_AARCH64_GENERIC = 'aarch64/generic'
2525

2626
EESSI_RPATH_OVERRIDE_ATTR = 'orig_rpath_override_dirs'
2727

@@ -160,6 +160,32 @@ def post_prepare_hook(self, *args, **kwargs):
160160
POST_PREPARE_HOOKS[self.name](self, *args, **kwargs)
161161

162162

163+
def parse_hook_casacore_disable_vectorize(ec, eprefix):
164+
"""
165+
Disable 'vectorize' toolchain option for casacore 3.5.0 on aarch64/neoverse_v1
166+
Compiling casacore 3.5.0 with GCC 13.2.0 (foss-2023b) gives an error when building for aarch64/neoverse_v1.
167+
See also, https://github.com/EESSI/software-layer/pull/479
168+
"""
169+
if ec.name == 'casacore':
170+
tcname, tcversion = ec['toolchain']['name'], ec['toolchain']['version']
171+
if (
172+
LooseVersion(ec.version) == LooseVersion('3.5.0') and
173+
tcname == 'foss' and tcversion == '2023b'
174+
):
175+
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
176+
if cpu_target == CPU_TARGET_NEOVERSE_V1:
177+
if not hasattr(ec, 'toolchainopts'):
178+
ec['toolchainopts'] = {}
179+
ec['toolchainopts']['vectorize'] = False
180+
print_msg("Changed toochainopts for %s: %s", ec.name, ec['toolchainopts'])
181+
else:
182+
print_msg("Not changing option vectorize for %s on non-neoverse_v1", ec.name)
183+
else:
184+
print_msg("Not changing option vectorize for %s %s %s", ec.name, ec.version, ec.toolchain)
185+
else:
186+
raise EasyBuildError("casacore-specific hook triggered for non-casacore easyconfig?!")
187+
188+
163189
def parse_hook_cgal_toolchainopts_precise(ec, eprefix):
164190
"""Enable 'precise' rather than 'strict' toolchain option for CGAL on POWER."""
165191
if ec.name == 'CGAL':
@@ -327,7 +353,7 @@ def pre_configure_hook_wrf_aarch64(self, *args, **kwargs):
327353
if LooseVersion(self.version) <= LooseVersion('3.9.0'):
328354
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure_new.defaults && " % (pattern, repl))
329355
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])
330-
356+
331357
if LooseVersion('4.0.0') <= LooseVersion(self.version) <= LooseVersion('4.2.1'):
332358
self.cfg.update('preconfigopts', "sed -i 's/%s/%s/g' arch/configure.defaults && " % (pattern, repl))
333359
print_msg("Using custom preconfigopts for %s: %s", self.name, self.cfg['preconfigopts'])
@@ -414,7 +440,7 @@ def pre_test_hook_ignore_failing_tests_netCDF(self, *args, **kwargs):
414440
"""
415441
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
416442
if self.name == 'netCDF' and self.version == '4.9.2' and cpu_target == CPU_TARGET_NEOVERSE_V1:
417-
self.cfg['testopts'] = "|| echo ignoring failing tests"
443+
self.cfg['testopts'] = "|| echo ignoring failing tests"
418444

419445
def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
420446
"""
@@ -579,6 +605,7 @@ def inject_gpu_property(ec):
579605

580606

581607
PARSE_HOOKS = {
608+
'casacore': parse_hook_casacore_disable_vectorize,
582609
'CGAL': parse_hook_cgal_toolchainopts_precise,
583610
'fontconfig': parse_hook_fontconfig_add_fonts,
584611
'OpenBLAS': parse_hook_openblas_relax_lapack_tests_num_errors,

0 commit comments

Comments
 (0)