Apply suggestions from code review

Co-authored-by: Kenneth Hoste <[email protected]>

Author: casparvl

create_lmodsitepackage.py

@@ -124,7 +124,7 @@
     if packagesList[simpleName] then
         -- simpleName is a module in packagesList
         -- first, check the old host_injections path prior to https://github.com/EESSI/software-layer-scripts/pull/59
-        -- If that exists, print a more targetted, explainatory warning
+        -- If that exists, print a more targetted, explanatory warning
         local previousHostInjections = string.gsub(os.getenv('EESSI_SOFTWARE_PATH') or "", 'versions', 'host_injections')
         local previousPackageEasyBuildDir = previousHostInjections .. "/software/" .. t.modFullName .. "/easybuild"
         local previousPackageDirExists = isDir(previousPackageEasyBuildDir)
@@ -142,7 +142,7 @@
             advice = advice .. "due to licencing. You will need to install a full copy of the " .. simpleName .. " package where EESSI "
             advice = advice .. "can find it.\\n"
             advice = advice .. "Note that a full copy is installed at " .. previousHostInjections .. "/software/" .. t.modFullName .. ". "
-            advice = advice .. "However, EESSI now expects it in a different location, namely at "
+            advice = advice .. "However, EESSI expects it in a different location since Aug'25, namely at "
             advice = advice .. hostInjections .. "/software/" .. t.modFullName .. ". "
             advice = advice .. "Please re-install the package at the new location. "
             advice = advice .. refer_to_docs

scripts/gpu_support/nvidia/install_cuda_and_libraries.sh

@@ -132,7 +132,7 @@ for EASYSTACK_FILE in ${TOPDIR}/easystacks/eessi-*CUDA*.yml; do
 
     # If there is a GPU on the node, the installation path will by default have an
     # accelerator subdirectory. For CUDA and cu*, these are binary installations and
-    # don't care about the target compute capability nor the CPU microarchitecture.
+    # we don't care about the target compute capability nor the CPU microarchitecture.
     # Our hooks are aware of this and therefore expect CUDA to be available under 
     # something like EESSI_SITE_SOFTWARE_PATH, but then with the CPU micro-architecture
     # stripped

scripts/gpu_support/nvidia/install_cuda_host_injections.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
 
 TOPDIR=$(dirname $(realpath $BASH_SOURCE))
-echo "This script was replaced by the $TOPDIR/install_cuda_and_libraries.sh script. See https://www.eessi.io/docs/site_specific_config/gpu/ for more information"
+echo "This script was replaced by the $TOPDIR/install_cuda_and_libraries.sh script. See https://www.eessi.io/docs/site_specific_config/gpu/ for more information" >&2
+exit 1