Skip to content

Conversation

@SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Jan 29, 2025

Extend did module

Extend DoubleMLData Classes

  • create data module
  • separate data classes into different files
  • create DoubleMLPanelData class

DiD Module

  • created did.datasets module including make_did_SZ2020
  • added make_did_CS2021 DGP
  • added DoubleMLDIDBinary class with flexible periods
  • added DoubleMLDIDMulti class for multiple periods

Reference to Issues or PRs

Comments

Compare to

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen added enhancement extension of existing feature new feature new feature labels Jan 29, 2025
@PhilippBach
Copy link
Member

Hi @SvenKlaassen
I realized that there's an issue when calling plot_effects() for only one treatment group, see #315

@SvenKlaassen SvenKlaassen marked this pull request as ready for review April 24, 2025 14:46
Copy link
Member

@PhilippBach PhilippBach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The changes look good to me.

@SvenKlaassen SvenKlaassen merged commit 5821ca7 into main Apr 25, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement extension of existing feature new feature new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Multi-Period DiD for Panel Data Rework the DID Sensitvitiy

3 participants