Skip to content

Commit e704544

Browse files
authored
Merge pull request #72 from DoubleML/m-fix-mw-cluster-nb
use localconverter; prevent depreciated pandas append
2 parents 70ac2fd + f74d703 commit e704544

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

doc/examples/py_double_ml_multiway_cluster.ipynb

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,8 @@
525525
"outputs": [],
526526
"source": [
527527
"from sklearn.preprocessing import PolynomialFeatures\n",
528-
"from rpy2.robjects.packages import importr, data\n",
529-
"from rpy2.robjects import r, pandas2ri\n",
530-
"pandas2ri.activate()"
528+
"from rpy2.robjects.packages import PackageData\n",
529+
"from rpy2.robjects import pandas2ri, default_converter, conversion"
531530
]
532531
},
533532
{
@@ -538,8 +537,9 @@
538537
},
539538
"outputs": [],
540539
"source": [
541-
"hdm = importr('hdm')\n",
542-
"blp_data = data(hdm).fetch('BLP')['BLP'][0]"
540+
"r_df = PackageData('hdm').fetch('BLP')['BLP'][0]\n",
541+
"with conversion.localconverter(default_converter + pandas2ri.converter):\n",
542+
" blp_data = conversion.rpy2py(r_df)"
543543
]
544544
},
545545
{
@@ -754,7 +754,7 @@
754754
"res = dml_pliv.summary.reset_index(drop=True)\n",
755755
"res['z_col'] = dml_data.z_cols[0]\n",
756756
"res['clustering'] = 'two-way'\n",
757-
"res_df = res_df.append(res)"
757+
"res_df = pd.concat([res_df, res]).reset_index(drop=True)"
758758
]
759759
},
760760
{
@@ -783,7 +783,7 @@
783783
"res = dml_pliv.summary.reset_index(drop=True)\n",
784784
"res['z_col'] = dml_data.z_cols[0]\n",
785785
"res['clustering'] = 'one-way-product'\n",
786-
"res_df = res_df.append(res)"
786+
"res_df = pd.concat([res_df, res]).reset_index(drop=True)"
787787
]
788788
},
789789
{
@@ -812,7 +812,7 @@
812812
"res = dml_pliv.summary.reset_index(drop=True)\n",
813813
"res['z_col'] = dml_data.z_cols[0]\n",
814814
"res['clustering'] = 'one-way-market'\n",
815-
"res_df = res_df.append(res)"
815+
"res_df = pd.concat([res_df, res]).reset_index(drop=True)"
816816
]
817817
},
818818
{
@@ -866,7 +866,7 @@
866866
"res = dml_pliv.summary.reset_index(drop=True)\n",
867867
"res['z_col'] = dml_data.z_cols[0]\n",
868868
"res['clustering'] = 'zero-way'\n",
869-
"res_df = res_df.append(res)"
869+
"res_df = pd.concat([res_df, res]).reset_index(drop=True)"
870870
]
871871
},
872872
{
@@ -988,7 +988,7 @@
988988
"provenance": []
989989
},
990990
"kernelspec": {
991-
"display_name": "Python 3",
991+
"display_name": "Python 3 (ipykernel)",
992992
"language": "python",
993993
"name": "python3"
994994
},
@@ -1002,7 +1002,7 @@
10021002
"name": "python",
10031003
"nbconvert_exporter": "python",
10041004
"pygments_lexer": "ipython3",
1005-
"version": "3.9.5"
1005+
"version": "3.9.7"
10061006
}
10071007
},
10081008
"nbformat": 4,

0 commit comments

Comments
 (0)