From 282c861bb8bf255b2d8ee867ab1f8c2efa50b881 Mon Sep 17 00:00:00 2001 From: Bruce Bujon Date: Thu, 19 Jun 2025 06:20:13 +0200 Subject: [PATCH 1/2] feat(ci): Add system tests check job to add in PR checks --- .github/workflows/run-system-tests.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/run-system-tests.yaml b/.github/workflows/run-system-tests.yaml index 2a2319e4a7e..76e4f93bbf5 100644 --- a/.github/workflows/run-system-tests.yaml +++ b/.github/workflows/run-system-tests.yaml @@ -62,3 +62,11 @@ jobs: scenarios_groups: tracer-release excluded_scenarios: CROSSED_TRACING_LIBRARIES,INTEGRATIONS_AWS,APM_TRACING_E2E_OTEL,APM_TRACING_E2E_SINGLE_SPAN,PROFILING # require AWS and datadog credentials skip_empty_scenarios: true + + # Ensure the main job is run to completion + check: + runs-on: ubuntu-latest + needs: + - main + steps: + - run: exit From bb7fc4de78f415f4b82a42ae8b898b4df8c14ae6 Mon Sep 17 00:00:00 2001 From: Bruce Bujon Date: Thu, 19 Jun 2025 06:35:58 +0200 Subject: [PATCH 2/2] feat(ci): Remove all green pipeline --- .github/workflows/README.md | 10 ------- .github/workflows/check-ci-pipelines.yml | 34 ------------------------ 2 files changed, 44 deletions(-) delete mode 100644 .github/workflows/check-ci-pipelines.yml diff --git a/.github/workflows/README.md b/.github/workflows/README.md index 3d8682e5e1a..188f1178fba 100644 --- a/.github/workflows/README.md +++ b/.github/workflows/README.md @@ -115,16 +115,6 @@ _Action:_ _Notes:_ Results are sent on both production and staging environments. -### check-ci-pipelines [🔗](check-ci-pipelines.yaml) - -_Trigger:_ When opening or updating a PR. - -_Action:_ This action will check all other continuous integration jobs (Github action, Gitlab, CircleCi), and will fail if any of them fails. -The purpose of this job is to be required for PR merges, achieving Green CI Policy. -It got an `ignored` parameters to exclude some jobs if they are temprorary failing. - -_Recovery:_ Manually trigger the action on the desired branch. - ### comment-on-submodule-update [🔗](comment-on-submodule-update.yaml) _Trigger:_ When creating a PR commits to `master` or a `release/*` branch with a Git Submodule update. diff --git a/.github/workflows/check-ci-pipelines.yml b/.github/workflows/check-ci-pipelines.yml deleted file mode 100644 index dd182f34369..00000000000 --- a/.github/workflows/check-ci-pipelines.yml +++ /dev/null @@ -1,34 +0,0 @@ -name: Check Pull Request CI Status - -on: - pull_request: - types: - - opened - - synchronize - - reopened - -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true - -permissions: - checks: read - statuses: read - -jobs: - check-ci-pipelines: - # Do not change this name, it must be equal to job id - # https://github.com/DataDog/ensure-ci-success/blob/main/docs/limitations.md#do-not-set-a-name-to-the-job-shipping-ensure-ci-success - name: check-ci-pipelines - runs-on: ubuntu-latest - steps: - - name: Run Ensure CI Success - uses: DataDog/ensure-ci-success@4a4b720e881d965254a9de2a4f14d1ec0c3d0d7c - with: - initial-delay-seconds: "500" - max-retries: "60" - ignored-name-patterns: | - dd-gitlab/.* - Check pull requests - -# gitlab pipelines are reported via dd-gitlab/default-pipeline status, which can be used as a GH status check