From a49cb73df70c610191faaae4929ca15e8b209c43 Mon Sep 17 00:00:00 2001 From: Stuart McCulloch Date: Tue, 18 Feb 2025 22:23:26 +0000 Subject: [PATCH] Actually use CleanupTask in TempLocationManager This task was never scheduled or executed, but its countdown-latch was waited on during shutdown. This resulted in the following log message each time a process was launched with profiling enabled: [dd.trace 2025-02-18 15:07:21:489 +0000] [Temp Location Manager Cleanup] INFO com.datadog.profiling.controller.TempLocationManager - Cleanup task timed out. /var/folders/6l/65lfwqj14ps6w4gt7495gly80000gq/T/ddprof/pid_4866 temp directory might not have been cleaned up properly --- .../com/datadog/profiling/controller/TempLocationManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java b/dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java index 589126d61a7..7b3a01e053e 100644 --- a/dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java +++ b/dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/TempLocationManager.java @@ -294,7 +294,7 @@ private TempLocationManager() { tempDir = baseTempDir.resolve(TEMPDIR_PREFIX + pid); if (runStartupCleanup) { // do not execute the background cleanup task when running in tests - AgentTaskScheduler.INSTANCE.execute(() -> cleanup(false)); + AgentTaskScheduler.INSTANCE.execute(cleanupTask); } Thread selfCleanup =