From d3ce6b1a3ed1430d81e8a17c87d51a1de1914545 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Thu, 29 Jun 2017 15:08:12 +0200 Subject: [PATCH 01/10] shading all stuff and removing from the scope all libs which can crash the app --- dd-java-agent-ittests/pom.xml | 6 +++++ dd-java-agent/pom.xml | 8 ++++++- dd-trace-annotations/pom.xml | 11 --------- dd-trace/pom.xml | 43 +++++++++++++++++++++-------------- pom.xml | 5 ++-- 5 files changed, 42 insertions(+), 31 deletions(-) diff --git a/dd-java-agent-ittests/pom.xml b/dd-java-agent-ittests/pom.xml index cfdd3bc03b6..31d8519f7e4 100644 --- a/dd-java-agent-ittests/pom.xml +++ b/dd-java-agent-ittests/pom.xml @@ -30,6 +30,12 @@ + + ch.qos.logback + logback-classic + 1.2.3 + test + io.opentracing opentracing-mock diff --git a/dd-java-agent/pom.xml b/dd-java-agent/pom.xml index 085b04136f4..076d9d89f6c 100644 --- a/dd-java-agent/pom.xml +++ b/dd-java-agent/pom.xml @@ -236,7 +236,13 @@ - + + + ch.qos.logback + logback-classic + 1.2.3 + test + io.opentracing opentracing-mock diff --git a/dd-trace-annotations/pom.xml b/dd-trace-annotations/pom.xml index bdd2a001794..35ed089adde 100644 --- a/dd-trace-annotations/pom.xml +++ b/dd-trace-annotations/pom.xml @@ -11,15 +11,4 @@ dd-trace-annotations https://github.com/datadog/dd-trace-java jar - - UTF-8 - - - - junit - junit - 3.8.1 - test - - diff --git a/dd-trace/pom.xml b/dd-trace/pom.xml index 723553ce334..b5349bbe4dd 100644 --- a/dd-trace/pom.xml +++ b/dd-trace/pom.xml @@ -56,11 +56,6 @@ slf4j-api 1.7.25 - - ch.qos.logback - logback-classic - 1.2.3 - @@ -70,6 +65,12 @@ + + ch.qos.logback + logback-classic + 1.2.3 + test + junit junit @@ -108,7 +109,7 @@ org.apache.maven.plugins maven-shade-plugin - 2.4.1 + 2.4.3 package @@ -119,23 +120,31 @@ com.fasterxml - dd.com.fasterxml + shaded.com.fasterxml - - - - - org.yaml - dd.org.yaml + com.google.guava + shaded.com.google.guava - org.slf4j - dd.org.slf4j + com.google.common + shaded.com.google.common + + + com.google.auto + shaded.com.google.auto + + + com.google.thirdparty + shaded.com.google.thirdparty - ch.qos - dd.ch.qos + org.yaml + shaded.org.yaml + + + org.slf4j + shaded.org.slf4j diff --git a/pom.xml b/pom.xml index 9da053e7461..954a7f33295 100644 --- a/pom.xml +++ b/pom.xml @@ -32,8 +32,8 @@ https://github.com/datadog/dd-trace-java scm:git:git://github.com/datadog/dd-trace-java.git scm:git:git@github.com:datadog/dd-trace-java.git - HEAD - + HEAD + dd-trace @@ -47,6 +47,7 @@ true 0.30.0 1.7 + UTF-8 From 359c0879f03715afebb2278f5356ada7015b7983 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Thu, 29 Jun 2017 19:42:58 +0200 Subject: [PATCH 02/10] fix shapping issues and pom refactoring --- dd-java-agent-ittests/pom.xml | 40 +---------------------------------- dd-java-agent/pom.xml | 37 +++++++++++++++++++++++++++++--- dd-trace/pom.xml | 19 ++--------------- 3 files changed, 37 insertions(+), 59 deletions(-) diff --git a/dd-java-agent-ittests/pom.xml b/dd-java-agent-ittests/pom.xml index 31d8519f7e4..92602fad043 100644 --- a/dd-java-agent-ittests/pom.xml +++ b/dd-java-agent-ittests/pom.xml @@ -11,7 +11,7 @@ dd-java-agent-ittests Datadog Java Agent integration tests https://github.com/datadog/dd-trace-java - pom + jar @@ -201,37 +201,15 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - 2.10.4 - - - attach-javadocs - - jar - - - - org.apache.maven.plugins maven-surefire-plugin 2.19 - - - - - *Test.java - - - -javaagent:${M2_REPO}/com/datadoghq/dd-java-agent/${project.version}/dd-java-agent-${project.version}.jar -Dorg.jboss.byteman.verbose=true - @@ -245,26 +223,10 @@ shade - - - - - - otarules.btm - - - com.datadoghq.trace.agent.AnnotationsTracingAgent - com.datadoghq.trace.agent.AnnotationsTracingAgent - - true - true - ./${project.artifactId}.jar - - diff --git a/dd-java-agent/pom.xml b/dd-java-agent/pom.xml index 076d9d89f6c..bc2dbb426d4 100644 --- a/dd-java-agent/pom.xml +++ b/dd-java-agent/pom.xml @@ -52,7 +52,6 @@ ${ot.agent.version} - org.reflections @@ -293,6 +292,39 @@ shade + + + + io.opentracing.contrib:opentracing-agent + org.jboss.byteman:byteman + + + + + javassist + shaded.javassist + + + org.reflections + shaded.org.reflections + + + com.fasterxml + shaded.com.fasterxml + + + com.google + shaded.com.google + + + org.yaml + shaded.org.yaml + + + org.slf4j + shaded.org.slf4j + + otarules.btm @@ -300,8 +332,7 @@ com.datadoghq.trace.agent.AnnotationsTracingAgent - com.datadoghq.trace.agent.AnnotationsTracingAgent - + com.datadoghq.trace.agent.AnnotationsTracingAgent true true ./${project.artifactId}.jar diff --git a/dd-trace/pom.xml b/dd-trace/pom.xml index b5349bbe4dd..76b6b4d1423 100644 --- a/dd-trace/pom.xml +++ b/dd-trace/pom.xml @@ -123,20 +123,8 @@ shaded.com.fasterxml - com.google.guava - shaded.com.google.guava - - - com.google.common - shaded.com.google.common - - - com.google.auto - shaded.com.google.auto - - - com.google.thirdparty - shaded.com.google.thirdparty + com.google + shaded.com.google org.yaml @@ -147,9 +135,6 @@ shaded.org.slf4j - - - From 3159cef4eada87d5a45d1c1e2ff660ee2d8318c8 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Fri, 30 Jun 2017 09:07:57 +0200 Subject: [PATCH 03/10] Force skipping tests for the moment --- dd-java-agent-ittests/pom.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/dd-java-agent-ittests/pom.xml b/dd-java-agent-ittests/pom.xml index 92602fad043..73724c6692e 100644 --- a/dd-java-agent-ittests/pom.xml +++ b/dd-java-agent-ittests/pom.xml @@ -17,6 +17,8 @@ true 0.1.2-SNAPSHOT + + true @@ -28,6 +30,14 @@ ${dd-trace.version} test + + + com.google.auto.service + auto-service + 1.0-rc3 + compile + + @@ -210,6 +220,7 @@ -javaagent:${M2_REPO}/com/datadoghq/dd-java-agent/${project.version}/dd-java-agent-${project.version}.jar -Dorg.jboss.byteman.verbose=true + ${skipTests} From 6bff68be6d3faf26b0903b233b51cff027e51ca3 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Thu, 29 Jun 2017 15:08:12 +0200 Subject: [PATCH 04/10] shading all stuff and removing from the scope all libs which can crash the app --- dd-trace/pom.xml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/dd-trace/pom.xml b/dd-trace/pom.xml index 76b6b4d1423..b5349bbe4dd 100644 --- a/dd-trace/pom.xml +++ b/dd-trace/pom.xml @@ -123,8 +123,20 @@ shaded.com.fasterxml - com.google - shaded.com.google + com.google.guava + shaded.com.google.guava + + + com.google.common + shaded.com.google.common + + + com.google.auto + shaded.com.google.auto + + + com.google.thirdparty + shaded.com.google.thirdparty org.yaml @@ -135,6 +147,9 @@ shaded.org.slf4j + + + From 5a582842ff95dfff0c27561a6eccfeeffa82d159 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Thu, 29 Jun 2017 19:42:58 +0200 Subject: [PATCH 05/10] fix shapping issues and pom refactoring --- dd-java-agent-ittests/pom.xml | 11 ----------- dd-trace/pom.xml | 19 ++----------------- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/dd-java-agent-ittests/pom.xml b/dd-java-agent-ittests/pom.xml index 73724c6692e..92602fad043 100644 --- a/dd-java-agent-ittests/pom.xml +++ b/dd-java-agent-ittests/pom.xml @@ -17,8 +17,6 @@ true 0.1.2-SNAPSHOT - - true @@ -30,14 +28,6 @@ ${dd-trace.version} test - - - com.google.auto.service - auto-service - 1.0-rc3 - compile - - @@ -220,7 +210,6 @@ -javaagent:${M2_REPO}/com/datadoghq/dd-java-agent/${project.version}/dd-java-agent-${project.version}.jar -Dorg.jboss.byteman.verbose=true - ${skipTests} diff --git a/dd-trace/pom.xml b/dd-trace/pom.xml index b5349bbe4dd..76b6b4d1423 100644 --- a/dd-trace/pom.xml +++ b/dd-trace/pom.xml @@ -123,20 +123,8 @@ shaded.com.fasterxml - com.google.guava - shaded.com.google.guava - - - com.google.common - shaded.com.google.common - - - com.google.auto - shaded.com.google.auto - - - com.google.thirdparty - shaded.com.google.thirdparty + com.google + shaded.com.google org.yaml @@ -147,9 +135,6 @@ shaded.org.slf4j - - - From e0e808e4c4ccbfedd5da73779f9c02248aac0e74 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Fri, 30 Jun 2017 09:07:57 +0200 Subject: [PATCH 06/10] Force skipping tests for the moment --- dd-java-agent-ittests/pom.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/dd-java-agent-ittests/pom.xml b/dd-java-agent-ittests/pom.xml index 92602fad043..73724c6692e 100644 --- a/dd-java-agent-ittests/pom.xml +++ b/dd-java-agent-ittests/pom.xml @@ -17,6 +17,8 @@ true 0.1.2-SNAPSHOT + + true @@ -28,6 +30,14 @@ ${dd-trace.version} test + + + com.google.auto.service + auto-service + 1.0-rc3 + compile + + @@ -210,6 +220,7 @@ -javaagent:${M2_REPO}/com/datadoghq/dd-java-agent/${project.version}/dd-java-agent-${project.version}.jar -Dorg.jboss.byteman.verbose=true + ${skipTests} From 1dc7d5a9b766d77fea9e8d3e17ab9b0c36ccf385 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Mon, 3 Jul 2017 11:42:35 +0200 Subject: [PATCH 07/10] AutoService is used by the deps, need to compile with maven --- dd-java-agent/pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dd-java-agent/pom.xml b/dd-java-agent/pom.xml index bc2dbb426d4..5437c0e4564 100644 --- a/dd-java-agent/pom.xml +++ b/dd-java-agent/pom.xml @@ -58,6 +58,12 @@ reflections 0.9.11 + + com.google.auto.service + auto-service + 1.0-rc3 + compile + From f7b34d7deba58321f30a0f6c68c9bf629631ed21 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Mon, 3 Jul 2017 11:44:47 +0200 Subject: [PATCH 08/10] Path has been changed. Fixing --- dd-java-agent-ittests/src/test/resources/dd-trace.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dd-java-agent-ittests/src/test/resources/dd-trace.yaml b/dd-java-agent-ittests/src/test/resources/dd-trace.yaml index 41ead394860..8c557c46254 100644 --- a/dd-java-agent-ittests/src/test/resources/dd-trace.yaml +++ b/dd-java-agent-ittests/src/test/resources/dd-trace.yaml @@ -21,7 +21,7 @@ sampler: # skipTagsPatterns: {"http.url": ".*/demo/add.*"} # Enable custom annotation tracing over a selected set of packages -enableCustomAnnotationTracingOver: ["io.opentracing.contrib.agent"] +enableCustomAnnotationTracingOver: ["com.datadoghq.trace.agent"] # Disable some instrumentations # disabledInstrumentations: ["apache http", "mongo", "jetty", "tomcat", ...] \ No newline at end of file From a150548a72e6086697ef06f9d2bfc35b428d81d7 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Mon, 3 Jul 2017 11:49:31 +0200 Subject: [PATCH 09/10] CircleCi --- dd-java-agent/pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/dd-java-agent/pom.xml b/dd-java-agent/pom.xml index 5437c0e4564..ac90af62a5b 100644 --- a/dd-java-agent/pom.xml +++ b/dd-java-agent/pom.xml @@ -62,7 +62,6 @@ com.google.auto.service auto-service 1.0-rc3 - compile From 73ab3d36ab0dcd60fb22b8f546bc91fef6cdd589 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Tue, 4 Jul 2017 10:57:47 +0200 Subject: [PATCH 10/10] Keep sync Maven and Gradle --- dd-java-agent-ittests/build.gradle | 1 + dd-java-agent/build.gradle | 2 ++ dd-trace/build.gradle | 1 + 3 files changed, 4 insertions(+) diff --git a/dd-java-agent-ittests/build.gradle b/dd-java-agent-ittests/build.gradle index fc8b289a2da..0207d986ee7 100644 --- a/dd-java-agent-ittests/build.gradle +++ b/dd-java-agent-ittests/build.gradle @@ -5,6 +5,7 @@ dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' testCompile group: 'org.assertj', name: 'assertj-core', version: '3.6.2' testCompile group: 'org.mockito', name: 'mockito-core', version: '2.7.22' + testCompile group: 'ch.qos.logback', name: 'logback-classic' , version: '1.2.3' testCompile group: 'org.mongodb', name: 'mongo-java-driver', version: '3.4.2' testCompile group: 'org.eclipse.jetty', name: 'jetty-server', version: '9.4.1.v20170120' testCompile group: 'org.eclipse.jetty', name: 'jetty-servlet', version: '9.4.1.v20170120' diff --git a/dd-java-agent/build.gradle b/dd-java-agent/build.gradle index 249a6eb7392..51c2cdb5942 100644 --- a/dd-java-agent/build.gradle +++ b/dd-java-agent/build.gradle @@ -12,6 +12,7 @@ dependencies { compile group: 'io.opentracing.contrib', name: 'opentracing-agent', version: '0.1.0' compile group: 'org.reflections', name: 'reflections', version: '0.9.11' + compile group: 'com.google.auto.service', name: 'auto-service', version: '1.0-rc3' compile(group: 'io.opentracing.contrib', name: 'opentracing-web-servlet-filter', version: '0.0.9') { @@ -45,6 +46,7 @@ dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' testCompile group: 'org.assertj', name: 'assertj-core', version: '3.6.2' testCompile group: 'org.mockito', name: 'mockito-core', version: '2.7.22' + testCompile group: 'ch.qos.logback', name: 'logback-classic' , version: '1.2.3' compileOnly group: 'org.eclipse.jetty', name: 'jetty-servlet', version: '9.3.6.v20151106' compileOnly group: 'org.apache.tomcat.embed', name: 'tomcat-embed-core', version: '9.0.0.M1' compileOnly group: 'org.mongodb', name: 'mongo-java-driver', version: '3.4.2' diff --git a/dd-trace/build.gradle b/dd-trace/build.gradle index b6c47a3eefa..7655fbd6d82 100644 --- a/dd-trace/build.gradle +++ b/dd-trace/build.gradle @@ -16,6 +16,7 @@ dependencies { testCompile group: 'junit', name: 'junit', version: '4.12' testCompile group: 'org.assertj', name: 'assertj-core', version: '3.6.2' testCompile group: 'org.mockito', name: 'mockito-core', version: '2.7.22' + testCompile group: 'ch.qos.logback', name: 'logback-classic' , version: '1.2.3' } shadowJar {