Error Logs Remediation (#9459)

Author: ygree

dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/ProfilerSettingsSupport.java

@@ -212,7 +212,8 @@ private static int getStackDepth() {
         try {
           return Integer.parseInt(value.substring(start, end));
         } catch (NumberFormatException e) {
-          logger.debug(SEND_TELEMETRY, "Failed to parse stack depth from JFR options: " + value, e);
+          logger.debug(
+              SEND_TELEMETRY, "Failed to parse stack depth from JFR options: {}", value, e);
         }
       }
     }

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/HelperInjector.java

@@ -158,7 +158,6 @@ public DynamicType.Builder<?> transform(
                 "Failed to inject helper classes - instrumentation.class="
                     + requestingName
                     + " instrumentation.target.classloader={} instrumentation.target.class={}",
-                requestingName,
                 classLoader,
                 typeDescription,
                 e);

telemetry/src/main/java/datadog/telemetry/log/LogPeriodicAction.java

@@ -63,16 +63,6 @@ private static String renderStackTrace(Throwable t) {
       } else {
         result.append(name);
       }
-
-      if (isDataDogCode(t)) {
-        String msg = t.getMessage();
-        result.append(": ");
-        if (msg == null || msg.isEmpty()) {
-          result.append(UNKNOWN);
-        } else {
-          result.append(msg);
-        }
-      }
       result.append('\n');
 
       final StackTraceElement[] stacktrace = t.getStackTrace();
@@ -127,18 +117,6 @@ private static int countCommonFrames(
     return count;
   }
 
-  private static boolean isDataDogCode(Throwable t) {
-    StackTraceElement[] stackTrace = t.getStackTrace();
-    if (stackTrace == null || stackTrace.length == 0) {
-      return false;
-    }
-    String cn = stackTrace[0].getClassName();
-    if (cn.isEmpty()) {
-      return false;
-    }
-    return cn.startsWith("datadog.") || cn.startsWith("com.datadog.");
-  }
-
   private static boolean shouldRedactClass(final String className) {
     for (final String prefix : PACKAGE_ALLOW_LIST) {
       if (className.startsWith(prefix)) {

telemetry/src/test/groovy/datadog/telemetry/log/LogPeriodicActionTest.groovy

@@ -50,7 +50,7 @@ class LogPeriodicActionTest extends DDSpecification {
     1 * telemetryService.addLogMessage(_) >> { args -> logMessage = args[0] }
     0 * _
     logMessage.getMessage() == 'test'
-    logMessage.getStackTrace() == "${MutableException.canonicalName}: exception\n" +
+    logMessage.getStackTrace() == "${MutableException.canonicalName}\n" +
       "  at datadog.MyClass.method(file:42)\n"
   }