Skip to content

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 6, 2023

  • Optionally add a description to the layer, useful for tracking branch names for RCs, agent version numbers, and potentially useful for production builds
  • Passes ownership of args to commands, as they are not reused by main.

@astuyve astuyve requested a review from a team as a code owner March 6, 2023 15:59
--region ${{ github.event.inputs.region }} \
--key ${{ secrets.GH_ACTION_PUBLISHER_AEM_KEY }}
--key ${{ secrets.GH_ACTION_PUBLISHER_AEM_KEY }} \
--description "${{ inputs.description }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you the GitHub action when description is empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test this actually! is there a good way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can write a integration test or manually trigger the workflow locally using https://cli.github.com/manual/gh_workflow_run

@duncanista
Copy link
Contributor

Closing due to #295 and tools have been moved to DataDog/serverless-tools.

@duncanista duncanista closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants