Skip to content

Commit cabc2a0

Browse files
committed
Env: dict -> Mapping
1 parent 5572024 commit cabc2a0

File tree

8 files changed

+10
-10
lines changed

8 files changed

+10
-10
lines changed

smartsim/settings/builders/launch/alps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def set(self, key: str, value: str | None) -> None:
220220
self._launch_args[key] = value
221221

222222
def finalize(
223-
self, exe: ExecutableLike, env: dict[str, str | None]
223+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
224224
) -> t.Sequence[str]:
225225
return (
226226
"aprun",

smartsim/settings/builders/launch/dragon.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def set(self, key: str, value: str | None) -> None:
6969
self._launch_args[key] = value
7070

7171
def finalize(
72-
self, exe: ExecutableLike, env: dict[str, str | None]
72+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
7373
) -> DragonRunRequest:
7474
exe_, *args = exe.as_program_arguments()
7575
return DragonRunRequest(

smartsim/settings/builders/launch/local.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,6 @@ def set(self, key: str, value: str | None) -> None:
7979
self._launch_args[key] = value
8080

8181
def finalize(
82-
self, exe: ExecutableLike, env: dict[str, str | None]
82+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
8383
) -> t.Sequence[str]:
8484
return exe.as_program_arguments()

smartsim/settings/builders/launch/lsf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def set(self, key: str, value: str | None) -> None:
122122
self._launch_args[key] = value
123123

124124
def finalize(
125-
self, exe: ExecutableLike, env: dict[str, str | None]
125+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
126126
) -> t.Sequence[str]:
127127
return (
128128
"jsrun",

smartsim/settings/builders/launch/mpi.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def launcher_str(self) -> str:
225225
return LauncherType.Mpirun.value
226226

227227
def finalize(
228-
self, exe: ExecutableLike, env: dict[str, str | None]
228+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
229229
) -> t.Sequence[str]:
230230
return ("mpirun", *self.format_launch_args(), "--", *exe.as_program_arguments())
231231

@@ -237,7 +237,7 @@ def launcher_str(self) -> str:
237237
return LauncherType.Mpiexec.value
238238

239239
def finalize(
240-
self, exe: ExecutableLike, env: dict[str, str | None]
240+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
241241
) -> t.Sequence[str]:
242242
return (
243243
"mpiexec",
@@ -254,7 +254,7 @@ def launcher_str(self) -> str:
254254
return LauncherType.Orterun.value
255255

256256
def finalize(
257-
self, exe: ExecutableLike, env: dict[str, str | None]
257+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
258258
) -> t.Sequence[str]:
259259
return (
260260
"orterun",

smartsim/settings/builders/launch/pals.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def set(self, key: str, value: str | None) -> None:
156156
self._launch_args[key] = value
157157

158158
def finalize(
159-
self, exe: ExecutableLike, env: dict[str, str | None]
159+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
160160
) -> t.Sequence[str]:
161161
return (
162162
"mpiexec",

smartsim/settings/builders/launch/slurm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ def set(self, key: str, value: str | None) -> None:
322322
self._launch_args[key] = value
323323

324324
def finalize(
325-
self, exe: ExecutableLike, env: dict[str, str | None]
325+
self, exe: ExecutableLike, env: t.Mapping[str, str | None]
326326
) -> t.Sequence[str]:
327327
return (
328328
"srun",

smartsim/settings/builders/launchArgBuilder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def set(self, arg: str, val: str | None) -> None:
5959
"""Set the launch arguments"""
6060

6161
@abstractmethod
62-
def finalize(self, exe: ExecutableLike, env: dict[str, str | None]) -> _T:
62+
def finalize(self, exe: ExecutableLike, env: t.Mapping[str, str | None]) -> _T:
6363
"""Prepare an entity for launch using the built options"""
6464

6565
def format_launch_args(self) -> t.Union[t.List[str], None]:

0 commit comments

Comments
 (0)