-
Notifications
You must be signed in to change notification settings - Fork 26
New logical (F)FBBasis2D tests #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aec7b7d to
7faf923
Compare
Codecov Report
@@ Coverage Diff @@
## develop #576 +/- ##
===========================================
- Coverage 86.53% 86.52% -0.02%
===========================================
Files 108 108
Lines 8287 8287
===========================================
- Hits 7171 7170 -1
- Misses 1116 1117 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
8e09642 to
6a6261b
Compare
|
Coverage looks ok. We lose one line of coverage here: ASPIRE-Python/src/aspire/basis/fb_2d.py Line 261 in 3223d6c
|
|
Not super proud of how the tests are parameterized, but haven't found a better way to do it with the |
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. It will be nice to drop those hardcoded tests. I just have a few questions for now.
c11c92c to
3c1fc6d
Compare
8344a84 to
5a6d862
Compare
Cast `Images` to arrays when needed.
To make sure we don't get the same inadvertent broadcasting bug again.
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just have a couple questions.
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This introduces some new tests in the spirit of #568. Since most of the tests (all except
testElement) apply to bothFBBasis2DandFFBBasis2D, these are structured as a mixin. There's probably a better way to do this, so I'm open to alternatives.Apart from this structural issue, what remains to do here is
FFBBasis2Dthat does something similar totestElementforFBBasis2D.Landdtype, since all the new tests work for arbitrary values of these parameters.