Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Closes #359 , hopefully restoring the automatic doc generation Vineet setup for us a while back.

@garrettwrong garrettwrong added bug Something isn't working documentation Improvements or additions to documentation CI Continuous Integration cleanup labels Dec 17, 2020
@garrettwrong garrettwrong requested a review from janden as a code owner December 17, 2020 01:24
@garrettwrong garrettwrong self-assigned this Dec 17, 2020
@janden
Copy link
Collaborator

janden commented Dec 17, 2020

Wouldn't it make more sense to add this to install_requires? (That's where sphinxcontrib-bibtex and co live.)

@garrettwrong
Copy link
Collaborator Author

I am not actually installing aspire on Travis directly anymore (that is actually the root of the issue). pip install aspire will already install sphinx... no need to add to setup.py, though I guess we could call it out.

Instead of the direct install, the CI tests is done inside tox virtual envs.

Im not 100% on this change resolving, maybe 90%, ... but I didn't really design this setup, just trying to work with it... As it is written it is sort of hard to iteratively test it.

@garrettwrong
Copy link
Collaborator Author

Now that Travis is defunct (we're out of time for the month on day 0), this isn't going to kick off anyway.

I'd still put this change in... and I can roll out the 0.6.2 package, then try to manually push the latest docs.

@janden
Copy link
Collaborator

janden commented Dec 17, 2020

That's funny…

Yeah let's do that, then.

@garrettwrong garrettwrong merged commit ce66208 into develop Dec 17, 2020
@garrettwrong garrettwrong deleted the fix_gh_pages_deployment branch December 17, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration cleanup documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants