Backport: API credit top-up telemetry + topupTrackerStore (#6500) #6502
Conversation
…udit events\n\n- Add TelemetryEvents.API_CREDIT_TOPUP_SUCCEEDED and provider method\n- Emit on credit_added events in useCustomerEventsService with in-memory dedupe\n- No local storage, naive based on backend audit log (cherry picked from commit 0a50e43)
(cherry picked from commit 37d8a53)
(cherry picked from commit fbf2aeb)
dosubot
bot
added
the
size:L
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/01/2025, 05:25:14 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const reconcileByFetchingEvents = async (): Promise<boolean> => { | ||
| const service = useCustomerEventsService() | ||
| const response = await service.getMyEvents({ page: 1, limit: 10 }) |
There was a problem hiding this comment.
The new reconcileByFetchingEvents action instantiates useCustomerEventsService(), but that composable calls useI18n() internally. useI18n requires an active Vue component instance, which is not present when reconcileByFetchingEvents runs (it is invoked from authActions.fetchBalance() and other event handlers after setup). This will throw getCurrentInstance()/useI18n errors as soon as fetchBalance is called, breaking balance refresh and the top‑up reconciliation flow. Consider moving the service call into a component/composable scope or refactoring the service to avoid useI18n when called from Pinia stores.
Useful? React with 👍 / 👎.
christian-byrne
added
the
claude-review
|
upstream changed, manually backporting |
Backport of #6500 onto
rh-test.Summary of changes
credit_addedaudit logs, emit telemetry on success, refresh balance, and clear pendingNotes
Validation
rh-testpnpm lint:fixandpnpm typechecklocallyPlease review backport diffs for any
rh-testbranch-specific interactions.┆Issue is synchronized with this Notion page by Unito