Note

pwendell · pwendell · commit fda0301a7ca2 · 2014-04-15T00:35:31.000-07:00
diff --git a/yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala b/yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala
@@ -332,6 +332,8 @@ trait ClientBase extends Logging {
       JAVA_OPTS += "-XX:CMSIncrementalDutyCycle=10"
     }
 
+    // TODO: it might be nicer to pass these as an internal environment variable rather than
+    // as Java options, due to complications with string parsing of nested quotes.
     if (args.amClass == classOf[ExecutorLauncher].getName) {
       // If we are being launched in client mode, forward the spark-conf options
       // onto the executor launcher

Original file line number	Diff line number	Diff line change
`@@ -332,6 +332,8 @@ trait ClientBase extends Logging {`
`332`	`332`	`JAVA_OPTS += "-XX:CMSIncrementalDutyCycle=10"`
`333`	`333`	`}`
`334`	`334`
	`335`	`+ // TODO: it might be nicer to pass these as an internal environment variable rather than`
	`336`	`+ // as Java options, due to complications with string parsing of nested quotes.`
`335`	`337`	`if (args.amClass == classOf[ExecutorLauncher].getName) {`
`336`	`338`	`// If we are being launched in client mode, forward the spark-conf options`
`337`	`339`	`// onto the executor launcher`