add the copy back

cloud-fan · cloud-fan · commit ed40d8f175b6 · 2015-08-08T17:53:53.000+08:00
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
@@ -137,7 +137,8 @@ class CodeGenContext {
     dataType match {
       case _ if isPrimitiveType(jt) => s"$row.set${primitiveTypeName(jt)}($ordinal, $value)"
       case t: DecimalType => s"$row.setDecimal($ordinal, $value, ${t.precision})"
-      case StringType => s"$row.update($ordinal, $value)"
+      // The UTF8String may came from UnsafeRow, otherwise clone is cheap (re-use the bytes)
+      case StringType => s"$row.update($ordinal, $value.clone())"
       case _ => s"$row.update($ordinal, $value)"
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,8 @@ class CodeGenContext {`
`137`	`137`	`dataType match {`
`138`	`138`	`case _ if isPrimitiveType(jt) => s"$row.set${primitiveTypeName(jt)}($ordinal, $value)"`
`139`	`139`	`case t: DecimalType => s"$row.setDecimal($ordinal, $value, ${t.precision})"`
`140`		`- case StringType => s"$row.update($ordinal, $value)"`
	`140`	`+ // The UTF8String may came from UnsafeRow, otherwise clone is cheap (re-use the bytes)`
	`141`	`+ case StringType => s"$row.update($ordinal, $value.clone())"`
`141`	`142`	`case _ => s"$row.update($ordinal, $value)"`
`142`	`143`	`}`
`143`	`144`	`}`